From: Shawn Guo <shawn.guo@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] pinctrl: mxs: warn if functions are not grouped by name
Date: Sat, 25 Oct 2014 20:24:35 +0800 [thread overview]
Message-ID: <20141025122433.GD3648@tiger> (raw)
In-Reply-To: <1413884445-28347-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Tue, Oct 21, 2014 at 11:40:45AM +0200, Uwe Kleine-König wrote:
> The mxs pinctrl driver cannot handle when functions are not grouped by
> name (which IMO is a bug). This happens for example if a
> imx28-somemachine.dts provides a function that has the same name as a
> function defined in imx28.dtsi.
>
> The proper way to fix that would be to check for duplicates in the loops
> (which increases parsing time) or parse the groups first and sort the
> resulting array.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-10-25 19:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 9:40 [PATCH] pinctrl: mxs: warn if functions are not grouped by name Uwe Kleine-König
2014-10-25 12:24 ` Shawn Guo [this message]
2014-10-30 14:53 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141025122433.GD3648@tiger \
--to=shawn.guo@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.