From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: Re: [PATCH v3 16/27] Mips/MSI: Save msi chip in pci sysdata Date: Sat, 25 Oct 2014 15:04:28 +0200 Message-ID: <20141025130428.GD16738@linux-mips.org> References: <1413342435-7876-1-git-send-email-wangyijing@huawei.com> <1413342435-7876-17-git-send-email-wangyijing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1413342435-7876-17-git-send-email-wangyijing@huawei.com> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Yijing Wang Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger List-Id: linux-arch.vger.kernel.org On Wed, Oct 15, 2014 at 11:07:04AM +0800, Yijing Wang wrote: > +static inline struct msi_chip *pci_msi_chip(struct pci_bus *bus) > +{ > + struct pci_controller *control = (struct pci_controller *)bus->sysdata; bus->sysdata is void * so this cast is unnecessary. Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eddie.linux-mips.org ([148.251.95.138]:44491 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbaJYScz (ORCPT ); Sat, 25 Oct 2014 14:32:55 -0400 Date: Sat, 25 Oct 2014 15:04:28 +0200 From: Ralf Baechle Subject: Re: [PATCH v3 16/27] Mips/MSI: Save msi chip in pci sysdata Message-ID: <20141025130428.GD16738@linux-mips.org> References: <1413342435-7876-1-git-send-email-wangyijing@huawei.com> <1413342435-7876-17-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1413342435-7876-17-git-send-email-wangyijing@huawei.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Yijing Wang Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf , Lucas Stach , David Vrabel , Sergei Shtylyov , Michael Ellerman , Thierry Reding , Thomas Petazzoni , Liviu Dudau Message-ID: <20141025130428.lz_YzYwwjDY9x9BKg62GU_ogAm4BG3TxEJ5v5IRTGqU@z> On Wed, Oct 15, 2014 at 11:07:04AM +0800, Yijing Wang wrote: > +static inline struct msi_chip *pci_msi_chip(struct pci_bus *bus) > +{ > + struct pci_controller *control = (struct pci_controller *)bus->sysdata; bus->sysdata is void * so this cast is unnecessary. Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Date: Sat, 25 Oct 2014 13:04:28 +0000 Subject: Re: [PATCH v3 16/27] Mips/MSI: Save msi chip in pci sysdata Message-Id: <20141025130428.GD16738@linux-mips.org> List-Id: References: <1413342435-7876-1-git-send-email-wangyijing@huawei.com> <1413342435-7876-17-git-send-email-wangyijing@huawei.com> In-Reply-To: <1413342435-7876-17-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yijing Wang Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf , Lucas Stach , David Vrabel , Sergei Shtylyov , Michael Ellerman , Thierry Reding , Thomas Petazzoni , Liviu Dudau On Wed, Oct 15, 2014 at 11:07:04AM +0800, Yijing Wang wrote: > +static inline struct msi_chip *pci_msi_chip(struct pci_bus *bus) > +{ > + struct pci_controller *control = (struct pci_controller *)bus->sysdata; bus->sysdata is void * so this cast is unnecessary. Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cvs.linux-mips.org (eddie.linux-mips.org [148.251.95.138]) by lists.ozlabs.org (Postfix) with ESMTP id 5E5381A015B for ; Sun, 26 Oct 2014 00:04:59 +1100 (AEDT) Received: from localhost.localdomain ([127.0.0.1]:33853 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S27010816AbaJYNE5OAsE6 (ORCPT ); Sat, 25 Oct 2014 15:04:57 +0200 Date: Sat, 25 Oct 2014 15:04:28 +0200 From: Ralf Baechle To: Yijing Wang Subject: Re: [PATCH v3 16/27] Mips/MSI: Save msi chip in pci sysdata Message-ID: <20141025130428.GD16738@linux-mips.org> References: <1413342435-7876-1-git-send-email-wangyijing@huawei.com> <1413342435-7876-17-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1413342435-7876-17-git-send-email-wangyijing@huawei.com> Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, Bharat.Bhushan@freescale.com, Thierry Reding , sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Russell King , Joerg Roedel , x86@kernel.org, Sebastian Ott , xen-devel@lists.xenproject.org, arnab.basu@freescale.com, Liviu Dudau , Arnd Bergmann , Konrad Rzeszutek Wilk , Chris Metcalf , Bjorn Helgaas , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , Xinwei Hu , Tony Luck , Sergei Shtylyov , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, David Vrabel , Wuyun , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Lucas Stach List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Oct 15, 2014 at 11:07:04AM +0800, Yijing Wang wrote: > +static inline struct msi_chip *pci_msi_chip(struct pci_bus *bus) > +{ > + struct pci_controller *control = (struct pci_controller *)bus->sysdata; bus->sysdata is void * so this cast is unnecessary. Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Date: Sat, 25 Oct 2014 13:04:28 +0000 Subject: Re: [PATCH v3 16/27] Mips/MSI: Save msi chip in pci sysdata Message-Id: <20141025130428.GD16738@linux-mips.org> List-Id: References: <1413342435-7876-1-git-send-email-wangyijing@huawei.com> <1413342435-7876-17-git-send-email-wangyijing@huawei.com> In-Reply-To: <1413342435-7876-17-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yijing Wang Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger On Wed, Oct 15, 2014 at 11:07:04AM +0800, Yijing Wang wrote: > +static inline struct msi_chip *pci_msi_chip(struct pci_bus *bus) > +{ > + struct pci_controller *control = (struct pci_controller *)bus->sysdata; bus->sysdata is void * so this cast is unnecessary. Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 From: ralf@linux-mips.org (Ralf Baechle) Date: Sat, 25 Oct 2014 15:04:28 +0200 Subject: [PATCH v3 16/27] Mips/MSI: Save msi chip in pci sysdata In-Reply-To: <1413342435-7876-17-git-send-email-wangyijing@huawei.com> References: <1413342435-7876-1-git-send-email-wangyijing@huawei.com> <1413342435-7876-17-git-send-email-wangyijing@huawei.com> Message-ID: <20141025130428.GD16738@linux-mips.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Oct 15, 2014 at 11:07:04AM +0800, Yijing Wang wrote: > +static inline struct msi_chip *pci_msi_chip(struct pci_bus *bus) > +{ > + struct pci_controller *control = (struct pci_controller *)bus->sysdata; bus->sysdata is void * so this cast is unnecessary. Ralf