All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: config: Add USB support example
Date: Sat, 25 Oct 2014 16:33:15 +0200	[thread overview]
Message-ID: <201410251633.16030.marex@denx.de> (raw)
In-Reply-To: <20141025111600.GA19417@amd>

On Saturday, October 25, 2014 at 01:16:00 PM, Pavel Machek wrote:
> On Fri 2014-10-24 23:34:25, Marek Vasut wrote:
> > Add example configuration stub for the DWC2 USB controller.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Vince Bridgers <vbridger@altera.com>
> > Cc: Pavel Machek <pavel@denx.de>
> > ---
> > 
> >  include/configs/socfpga_common.h | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/include/configs/socfpga_common.h
> > b/include/configs/socfpga_common.h index 9de3aa7..1df886b 100644
> > --- a/include/configs/socfpga_common.h
> > +++ b/include/configs/socfpga_common.h
> > @@ -176,6 +176,21 @@
> > 
> >  #define CONFIG_BAUDRATE			115200
> >  
> >  /*
> > 
> > + * USB
> > + */
> > +#ifdef CONFIG_CMD_USB
> > +#define CONFIG_USB_DWC2
> > +#define CONFIG_USB_STORAGE
> > +/*
> > + * NOTE: User must define either of the following to select which
> > + *       of the two USB controllers available on SoCFPGA to use.
> > + *       The DWC2 driver doesn't support multiple USB controllers.
> > + * #define CONFIG_USB_DWC2_REG_ADDR	SOCFPGA_USB0_ADDRESS
> > + * #define CONFIG_USB_DWC2_REG_ADDR	SOCFPGA_USB1_ADDRESS
> > + */
> > +#endif
> > +
> > +/*
> 
> Actually, I believe you should uncomment whatever configuration works
> for you. That way, users can see what you are actually using/testing.

This is common config code, the user is supposed to define his own setup in
board config code (ie. socfpga_cyclone5.h) . A subsequent patch doing just
that would be fine.

> With that:
> 
> Acked-by: Pavel Machek <pavel@denx.de>
> 									Pavel

Best regards,
Marek Vasut

  reply	other threads:[~2014-10-25 14:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24 21:34 [U-Boot] [PATCH] arm: socfpga: config: Add USB support example Marek Vasut
2014-10-25 11:16 ` Pavel Machek
2014-10-25 14:33   ` Marek Vasut [this message]
2014-10-27  1:25 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201410251633.16030.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.