From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ARM: mxs: Enable DCDC converter for battery boot
Date: Sun, 26 Oct 2014 00:42:30 +0200 [thread overview]
Message-ID: <201410260042.30482.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5AMXcR_yhGWoVZw4rXeCG=8ej0n8+mSPdFJk039O61Cmg@mail.gmail.com>
On Saturday, October 25, 2014 at 11:43:05 PM, Fabio Estevam wrote:
> Hi Michael,
>
> On Thu, Oct 23, 2014 at 5:07 AM, Michael Thalmeier
>
> <michael.thalmeier@hale.at> wrote:
> > Hi Marek, and Fabio
> >
> >> > Shouldn't this be conditional?
> >> >
> >> > #if defined CONFIG_MXS_ENABLE_4P2
> >> > mxs_power_enable_4p2();
> >> > #endif
> >> >
> >> > Then the boards that need this power supply enable
> >> > CONFIG_MXS_ENABLE_4P2 in its config file.
> >>
> >> No, we want to start the DCDC converter unconditionally when running on
> >
> > battery
> >
> >> power to increase efficiency.
> >
> > I just stumbled upon this, because our board does not boot reliably any
> > more with this change.
> > Perhaps we have a special situation in that our board is powered via
> > DCDC_BATT only by an external power source (no battery).
> >
> > I am currently working on creating a patch to only conditionally enabling
> > this feature, or to enable it by default and have it conditionally be
> > disabled for boards that are known to have problems with this.
> >
> > Which approach seems to be more feasible to you?
>
> Initially I proposed something like:
>
> #if defined CONFIG_MXS_ENABLE_4P2
> mxs_power_enable_4p2();
> #endif
>
> ,but Marek was not happy about it, so let's wait for his thoughts. Marek?
Can you share the schematic of your power distribution network ? I would like
to check a couple of things in there. I suspect there is a common problem with
MX23 and MX28 based designs discovered by Juha and I'd like to make sure you
don't suffer from it.
It's OK to send the schematic off-list.
Thanks!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-10-25 22:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 11:29 [U-Boot] [PATCH 1/2] ARM: mxs: Enable DCDC converter for battery boot Marek Vasut
2013-10-28 11:29 ` [U-Boot] [PATCH 2/2] ARM: mxs: Configure 2 Gbit DDR2 RAM for BG0900 Marek Vasut
2013-10-31 17:03 ` Stefano Babic
2013-10-29 1:46 ` [U-Boot] [PATCH 1/2] ARM: mxs: Enable DCDC converter for battery boot Fabio Estevam
2013-10-29 15:28 ` Marek Vasut
2014-10-23 7:07 ` Michael Thalmeier
2014-10-25 21:43 ` Fabio Estevam
2014-10-25 22:42 ` Marek Vasut [this message]
2013-10-31 17:02 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201410260042.30482.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.