All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] tools/socfpgaimage.c: fix build on darwin
Date: Sun, 26 Oct 2014 00:51:05 +0200	[thread overview]
Message-ID: <201410260051.05506.marex@denx.de> (raw)
In-Reply-To: <20141025092551.GA12204@amd>

On Saturday, October 25, 2014 at 11:25:51 AM, Pavel Machek wrote:
> On Fri 2014-10-24 23:40:13, Marek Vasut wrote:
> > On Friday, October 24, 2014 at 11:39:10 PM, andreas.devel at googlemail.com 
wrote:
> > > From: Andreas Bie?mann <andreas.devel@googlemail.com>
> > > 
> > > socfpgaimage utilizes htole32 and friends, unfortunately these
> > > functions are not available on darwin. Fix it by using the cpu_to_le32
> > > and friends defined in compiler.h as other parts in mkimage do.
> > > 
> > > This patch fixes the following error:
> > > ---8<---
> > > 
> > >   HOSTCC  tools/socfpgaimage.o
> > > 
> > > tools/socfpgaimage.c:77:22: warning: implicit declaration of function
> > > 'htole32' is invalid in C99 [-Wimplicit-function-declaration]
> > > header.validation = htole32(VALIDATION_WORD);
> > > 
> > >                             ^
> > > 
> > > tools/socfpgaimage.c:80:22: warning: implicit declaration of function
> > > 'htole16' is invalid in C99 [-Wimplicit-function-declaration]
> > > header.length_u32 = htole16(length_bytes/4);
> > > 
> > >                             ^
> > > 
> > > tools/socfpgaimage.c:95:6: warning: implicit declaration of function
> > > 'le32toh' is invalid in C99 [-Wimplicit-function-declaration] if
> > > (le32toh(header.validation) != VALIDATION_WORD)
> > > 
> > >             ^
> > > 
> > > tools/socfpgaimage.c:97:6: warning: implicit declaration of function
> > > 'le16toh' is invalid in C99 [-Wimplicit-function-declaration] if
> > > (le16toh(header.checksum) != hdr_checksum(&header))
> > > 
> > >             ^
> > > 
> > > 4 warnings generated.
> > > ...
> > > 
> > >   HOSTLD  tools/dumpimage
> > > 
> > > Undefined symbols for architecture x86_64:
> > >   "_htole16", referenced from:
> > >       _socfpgaimage_set_header in socfpgaimage.o
> > >   
> > >   "_htole32", referenced from:
> > >       _socfpgaimage_set_header in socfpgaimage.o
> > >   
> > >   "_le16toh", referenced from:
> > >       _verify_buffer in socfpgaimage.o
> > >   
> > >   "_le32toh", referenced from:
> > >       _verify_buffer in socfpgaimage.o
> > > 
> > > ld: symbol(s) not found for architecture x86_64
> > > --->8---
> > > 
> > > Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
> > 
> > Acked-by: Marek Vasut <marex@denx.de>
> 
> Acked-by: Pavel Machek <pavel@denx.de>

Applied, thanks.

Best regards,
Marek Vasut

  reply	other threads:[~2014-10-25 22:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24 21:39 [U-Boot] [PATCH 0/2] Fix u-boot compile on darwin host andreas.devel at googlemail.com
2014-10-24 21:39 ` [U-Boot] [PATCH 1/2] tools/socfpgaimage.c: fix build on darwin andreas.devel at googlemail.com
2014-10-24 21:40   ` Marek Vasut
2014-10-25  9:25     ` Pavel Machek
2014-10-25 22:51       ` Marek Vasut [this message]
2014-10-24 21:39 ` [U-Boot] [PATCH 2/2] tools/kwbimage.c: " andreas.devel at googlemail.com
2014-10-27  7:14   ` Stefan Roese
2014-10-30 22:11   ` Anatolij Gustschin
2014-10-30 23:27     ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201410260051.05506.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.