From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: Request for comments for SND_SOC_IMX_WM8731 Date: Sun, 26 Oct 2014 00:40:17 -0700 Message-ID: <20141026074017.GA6268@Asurada> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by alsa0.perex.cz (Postfix) with ESMTP id 1A506260494 for ; Sun, 26 Oct 2014 08:40:26 +0100 (CET) Received: by mail-pd0-f170.google.com with SMTP id z10so3799222pdj.29 for ; Sun, 26 Oct 2014 00:40:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Jonathan Bennett Cc: "alsa-devel@alsa-project.org" , Mark Brown , Aaron Kling , Igor Grinberg , Valentin Raevsky , Fabio Estevam List-Id: alsa-devel@alsa-project.org Hi Jonathan, On Fri, Oct 24, 2014 at 10:20:29AM -0200, Fabio Estevam wrote: > On Fri, Oct 24, 2014 at 2:42 AM, Jonathan Bennett wrote: > > This patch is a continuation of my work on supporting the Utilite devices on > > the vanilla kernel. I've modified the code slightly to conform to > > established practice. Namely instead of using src-port and ext-port, we use > > mux-int-port and mux-ext-port. > > > > This driver has support for putting the codec in either master mode or slave > > mode. So far I've only had success with using slave mode. For trying to > > submit for kernel inclusion, should I strip out the code for codec master Just took a look at your driver. And I have a suggestion on the top of Fabio's comments. I think you should try fsl-asoc-card driver instead of adding this one. Your driver doesn't seemly have some specific requirement and it actually contains a few out-of-date code like SSI clock divider settings. SSI driver now has the capability to calculate divisors automatically based on the required sample rate, even if it may not be perfect to apply all the sample rates. But I don't think the machine driver shall take care this job any more. So I suggest you first to try the fsl-asoc-card with a specific change for wm8731 to make it work -- I think you only need to configure some parameters in its probe() as I did for the other CODECs. If it doesn't work out, you can raise the problem. I'll also help on it. Thanks, Nicolin