All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de
Subject: Re: [PATCH bluetooth-next 14/15] mac802154: tx: add comment at sync xmit callback
Date: Sun, 26 Oct 2014 09:25:31 +0100	[thread overview]
Message-ID: <20141026082529.GA18082@omega> (raw)
In-Reply-To: <1414311352-908-15-git-send-email-alex.aring@gmail.com>

Hi,

On Sun, Oct 26, 2014 at 09:15:51AM +0100, Alexander Aring wrote:
> This patch adds a warning that xmit_sync callback is deprecated and
> should be removed soon. The 802.15.4 subsystem will not accept synced
> drivers anymore.
> 
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
>  include/net/mac802154.h | 4 ++++
>  net/mac802154/tx.c      | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/include/net/mac802154.h b/include/net/mac802154.h
> index 57b1202..942dd53 100644
> --- a/include/net/mac802154.h
> +++ b/include/net/mac802154.h
> @@ -117,6 +117,10 @@ struct ieee802154_hw {
>   *	  synchronous 802.15.4 drivers.
>   *	  This function should return zero or negative errno.
>   *
> + *	  WARNING:
> + *	  This will be deprecated soon. We don't accept synced xmit callbacks
> + *	  drivers anymore.
> + *
>   * xmit_async:
>   *	  Handler that 802.15.4 module calls for each transmitted frame.
>   *	  skb cntains the buffer starting from the IEEE 802.15.4 header.
> diff --git a/net/mac802154/tx.c b/net/mac802154/tx.c
> index 74882c7..402701d 100644
> --- a/net/mac802154/tx.c
> +++ b/net/mac802154/tx.c
> @@ -30,6 +30,7 @@
>  
>  /* IEEE 802.15.4 transceivers can sleep during the xmit session, so process
>   * packets through the workqueue.
> + *

hmpf, didn't see the line insertion here. I will send a v2.

Doing much rebase stuff and at first it was at this position.

- Alex

  reply	other threads:[~2014-10-26  8:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-26  8:15 [PATCH bluetooth-next 00/15] ieee802154: rework transmit handling Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 01/15] mac802154: tx: move xmit callback to tx file Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 02/15] mac802154: tx: remove kmalloc in xmit hotpath Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 03/15] mac802154: tx: squash multiple dereferencing Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 04/15] mac802154: tx: remove xmit channel context switch Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 05/15] mac802154: add netdev qeue helpers Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 06/15] mac802154: tx: use queue helpers in xmit worker Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 07/15] mac802154: tx: fix error handling while xmit Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 08/15] mac802154: tx: add support for xmit_async callback Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 09/15] mac802154: tx: don't allow if down while sync tx Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 10/15] mac802154: tx: use netdev print helpers Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 11/15] mac802154: tx: cleanup crc calculation Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 12/15] mac802154: tx: move stats tx increment Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 13/15] mac802154: tx: change naming convention Alexander Aring
2014-10-26  8:15 ` [PATCH bluetooth-next 14/15] mac802154: tx: add comment at sync xmit callback Alexander Aring
2014-10-26  8:25   ` Alexander Aring [this message]
2014-10-26  8:15 ` [PATCH bluetooth-next 15/15] at86rf230: asynchronous xmit handling Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141026082529.GA18082@omega \
    --to=alex.aring@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.