From: Jeff King <peff@peff.net>
To: David Michael <fedora.dm0@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule
Date: Sun, 26 Oct 2014 22:17:05 -0700 [thread overview]
Message-ID: <20141027051705.GC2996@peff.net> (raw)
In-Reply-To: <CAEvUa7nMYn1EJhrX+Yo-T53-tqB80p_ym9i+Ua6PMLqZrAFmQw@mail.gmail.com>
On Sun, Oct 26, 2014 at 02:54:56PM -0400, David Michael wrote:
> Yes, the compiler refuses to run by default when a "-L" option occurs
> after a source/object file. It tries to interpret it as another file
> name and fails.
Yeah, I think I have seen similar behavior before, but it has been long
enough that I no longer remember the compiler in use.
> I believe I can work around the error with an "export _C89_CCMODE=1",
> but I thought I'd send the patch since this is the only occurrence of
> the problem, and the argument order is inconsistent with other linker
> commands in the file.
I don't think working around it makes sense. That would fix your case,
but nobody else's (though given how long it has been that way without
complaints, I suspect any other compilers this picky may have died off).
> Do you want me to resend the patch and reference the IBM documentation
> in the message?
I don't think you need to. More interesting than documentation is the
real-world breakage you experienced and the analysis of the situation.
I'd be fine taking the patch as-is, or if changing anything, mentioning
the failure mode in the commit message.
-Peff
next prev parent reply other threads:[~2014-10-27 5:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 17:33 [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule David Michael
2014-10-26 17:45 ` Eric Sunshine
2014-10-26 18:35 ` Jeff King
2014-10-26 18:54 ` David Michael
2014-10-27 5:17 ` Jeff King [this message]
2014-10-27 17:42 ` Junio C Hamano
2014-10-28 22:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027051705.GC2996@peff.net \
--to=peff@peff.net \
--cc=fedora.dm0@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.