From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [RFC/PATCH] PM / Sleep: Timer quiesce in freeze state Date: Mon, 27 Oct 2014 08:28:16 +0100 Message-ID: <20141027072816.GD10501@worktop.programming.kicks-ass.net> References: <5446787E.60202@linux.intel.com> <20141024153656.GM12706@worktop.programming.kicks-ass.net> <544DE5CF.9040501@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:46845 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbaJ0H21 (ORCPT ); Mon, 27 Oct 2014 03:28:27 -0400 Content-Disposition: inline In-Reply-To: <544DE5CF.9040501@linux.intel.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Li, Aubrey" Cc: "Rafael J. Wysocki" , "Brown, Len" , "alan@linux.intel.com" , Thomas Gleixner , "H. Peter Anvin" , linux-kernel@vger.kernel.org, "linux-pm@vger.kernel.org >> Linux PM list" On Mon, Oct 27, 2014 at 02:27:27PM +0800, Li, Aubrey wrote: > > Now I suppose the problem is with cpu_pause() which needs IPIs to > > complete? Do we really need cpuidle_pause() there? > > cpuidle_uninstall_handlers() seems like a daft thing to call just about > > there. > > Please check the log of 8651f97bd951d0bb1c10fa24e3fa3455193f3548. > Rafael should know more this question than me. That changelog explains its complete bollocks to do it here. We _want_ to enter and/or remain in deep idle states.