From: Brian Foster <bfoster@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: fix endian mishap in xfs_dialloc_ag()
Date: Mon, 27 Oct 2014 07:25:54 -0400 [thread overview]
Message-ID: <20141027112552.GA39598@bfoster.bfoster> (raw)
In-Reply-To: <54498FE9.4000103@redhat.com>
On Thu, Oct 23, 2014 at 06:31:53PM -0500, Eric Sandeen wrote:
> Fixes a regression introduced by:
>
> 88fc730 xfs: use and update the finobt on inode allocation
>
> which passed the non-swapped version of agi->agi_newino to
> xfs_inobt_lookup()
>
> Caught by make C=2, ftw!
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> diff --git a/libxfs/xfs_ialloc.c b/libxfs/xfs_ialloc.c
> index 5462c54..b20a9ec 100644
> --- a/libxfs/xfs_ialloc.c
> +++ b/libxfs/xfs_ialloc.c
> @@ -1057,7 +1057,8 @@ xfs_dialloc_ag(
> * most recently allocated inode.
> */
> if (agi->agi_newino != cpu_to_be32(NULLAGINO)) {
> - error = xfs_inobt_lookup(cur, agi->agi_newino,
> + error = xfs_inobt_lookup(cur,
> + be32_to_cpu(agi->agi_newino),
> XFS_LOOKUP_EQ, &i);
> if (error)
> goto error_cur;
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-10-27 11:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 23:31 [PATCH] xfsprogs: fix endian mishap in xfs_dialloc_ag() Eric Sandeen
2014-10-27 11:25 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027112552.GA39598@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.