From: Brian Foster <bfoster@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: two more completely harmless sparse nits
Date: Mon, 27 Oct 2014 07:26:10 -0400 [thread overview]
Message-ID: <20141027112609.GC39598@bfoster.bfoster> (raw)
In-Reply-To: <5449964F.1040504@redhat.com>
On Thu, Oct 23, 2014 at 06:59:11PM -0500, Eric Sandeen wrote:
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> diff --git a/repair/prefetch.c b/repair/prefetch.c
> index 65f8456..7ea0d36 100644
> --- a/repair/prefetch.c
> +++ b/repair/prefetch.c
> @@ -171,7 +171,7 @@ pf_read_bmbt_reclist(
> struct xfs_buf_map map_array[MAP_ARRAY_SZ];
> struct xfs_buf_map *map = map_array;
> int max_extents = MAP_ARRAY_SZ;
> - int nmaps = 0;;
> + int nmaps = 0;
> unsigned int len = 0;
> int ret = 0;
>
> diff --git a/rtcp/xfs_rtcp.c b/rtcp/xfs_rtcp.c
> index b81b1e1..5f26a62 100644
> --- a/rtcp/xfs_rtcp.c
> +++ b/rtcp/xfs_rtcp.c
> @@ -25,7 +25,7 @@ int pflag;
> char *progname;
>
> void
> -usage()
> +usage(void)
> {
> fprintf(stderr, _("%s [-e extsize] [-p] [-V] source target\n"), progname);
> exit(2);
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-10-27 11:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 23:59 [PATCH] xfsprogs: two more completely harmless sparse nits Eric Sandeen
2014-10-27 11:26 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027112609.GC39598@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.