From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gioh Kim <gioh.kim@lge.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
John Stultz <john.stultz@linaro.org>,
Rebecca Schultz Zavin <rebecca@android.com>,
devel@driverdev.osuosl.org, gunho.lee@lge.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 2/2] staging: ion: debugfs to shrink pool
Date: Mon, 27 Oct 2014 15:52:48 +0300 [thread overview]
Message-ID: <20141027125247.GB6890@mwanda> (raw)
In-Reply-To: <20141027114240.GC6879@mwanda>
On Mon, Oct 27, 2014 at 02:42:40PM +0300, Dan Carpenter wrote:
> On Thu, Oct 23, 2014 at 09:52:20PM +0900, Gioh Kim wrote:
> > This patch creates debugfs files, /sys/kernel/debug/ion/heaps/system_shrink,
> > to shrink pool or get pool size.
> > Reading the file returns pool size and writing occurs to shrink pool.
>
> The patch looks fine. Of course, the original code was debugfs before
> it bitrotted and stopped compiling, but is there there a reason why we
> shouldn't move this to sysfs instead? Just curious.
>
I read the Laura's review comments and it turns out we don't want this
enabled by default and debugfs is fine. Question answered.
regards,
dan carpenter
prev parent reply other threads:[~2014-10-27 12:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 12:52 [RFC 0/2] enable pool shrinking in page unit Gioh Kim
2014-10-23 12:52 ` [RFC 1/2] staging: ion: shrink page-pool by " Gioh Kim
2014-10-23 20:36 ` Devendra Naga
2014-10-23 23:16 ` Gioh Kim
2014-10-23 23:31 ` Gioh Kim
2014-10-23 23:49 ` Devendra Naga
2014-10-23 12:52 ` [RFC 2/2] staging: ion: debugfs to shrink pool Gioh Kim
2014-10-27 11:42 ` Dan Carpenter
2014-10-27 12:52 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027125247.GB6890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gioh.kim@lge.com \
--cc=gregkh@linuxfoundation.org \
--cc=gunho.lee@lge.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rebecca@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.