From: Andi Kleen <ak@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
mingo@kernel.org, tglx@linutronix.de, eranian@google.com,
dzickus@redhat.com, jmario@redhat.com, acme@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Attempt to cleanup the HSW offcore bits
Date: Mon, 27 Oct 2014 07:28:18 -0700 [thread overview]
Message-ID: <20141027142818.GA3041@tassilo.jf.intel.com> (raw)
In-Reply-To: <20141027130712.GF3337@twins.programming.kicks-ass.net>
On Mon, Oct 27, 2014 at 02:07:12PM +0100, Peter Zijlstra wrote:
> On Mon, Oct 27, 2014 at 01:23:40PM +0100, Andi Kleen wrote:
> > On Thu, Oct 23, 2014 at 12:51:19PM +0200, Peter Zijlstra wrote:
> > > So Don asked about offcore and because I forgot I looked at the code and found
> > > the terrible mess Andi created with the HSW/BDW bits.
> > >
> > > This series attempts to clean some of that up but seeing how it was all magic
> > > numbers
> >
> > All the bits are documented. The actual definitions are available
> > in the JSON offcore definitions at https://download.01.org/perfmon/
>
> Yeah, no. That's not how we write code. Also, there's no actual JSON
> offcore file for HSW only some TSV file, and I've no mind to go decode
https://download.01.org/perfmon/HSW/Haswell_matrix_V14.json
https://download.01.org/perfmon/HSW/Haswell_matrix_bit_definitions_V14.json
-Andi
next prev parent reply other threads:[~2014-10-27 14:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 10:51 [PATCH 0/4] Attempt to cleanup the HSW offcore bits Peter Zijlstra
2014-10-23 10:51 ` [PATCH 1/4] perf,x86: De-obfuscate " Peter Zijlstra
2014-10-23 12:16 ` Borislav Petkov
2014-10-23 13:13 ` Peter Zijlstra
2014-10-23 10:51 ` [PATCH 2/4] perf,x86: HSW offcore prefetch events Peter Zijlstra
2014-10-23 10:51 ` [PATCH 3/4] perf,x86: Attempt to sanitize the HSW supplier info Peter Zijlstra
2014-10-23 10:51 ` [PATCH 4/4] perf,x86: Introduce HSW cache numa events Peter Zijlstra
2014-10-27 12:23 ` [PATCH 0/4] Attempt to cleanup the HSW offcore bits Andi Kleen
2014-10-27 13:07 ` Peter Zijlstra
2014-10-27 14:28 ` Andi Kleen [this message]
2014-10-27 14:48 ` Peter Zijlstra
2014-10-28 21:53 ` Thomas Gleixner
2014-10-29 11:00 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027142818.GA3041@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dzickus@redhat.com \
--cc=eranian@google.com \
--cc=jmario@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.