From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH 1/8] eeepc-laptop: flatten control flow Date: Mon, 27 Oct 2014 21:56:31 -0700 Message-ID: <20141028045631.GD60814@vmdeb7> References: <1414005163-3461-1-git-send-email-fransklaver@gmail.com> <1414005163-3461-2-git-send-email-fransklaver@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1414005163-3461-2-git-send-email-fransklaver@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Frans Klaver Cc: Corentin Chary , acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Wed, Oct 22, 2014 at 09:12:36PM +0200, Frans Klaver wrote: > In eeepc_rfkill_hotplug there's an if statement with a big tail that > ends right before the out_unlock label. We might as well invert the > condition and jump to out_unlock in that case, pretty much like the rest > of the code does. This removes an indentation level for a large chunk of > code and also stops suggesting there might be an else clause. > > Signed-off-by: Frans Klaver Queued for 3.19, thanks Frans. -- Darren Hart Intel Open Source Technology Center