From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 0/3] raw-posix: Fix raw_co_get_block_status()
Date: Tue, 28 Oct 2014 15:27:48 +0100 [thread overview]
Message-ID: <20141028142748.GD4828@noname.str.redhat.com> (raw)
In-Reply-To: <1414148280-17949-1-git-send-email-mreitz@redhat.com>
Am 24.10.2014 um 12:57 hat Max Reitz geschrieben:
> raw_co_get_block_status() should return 0 and set *pnum to 0 after the
> EOF; currently it does this merely by accident, so implement it
> directly. Also, nb_sectors should be clamped against the image end.
>
> While doing that, centralize the generation of
> raw_co_get_block_status()'s return value along the way.
>
>
> v4:
> - Patch 1: Use DIV_ROUND_UP() for the range until the image end instead
> of truncating integer division [Eric]
> - Patch 3:
> - Use qemu-img resize -f raw instrad of truncate [Eric]
> - Use qemu with HMP qemu-io instead of qemu-io itself; drop the
> qemu-img test [Eric]
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2014-10-28 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 10:57 [Qemu-devel] [PATCH v4 0/3] raw-posix: Fix raw_co_get_block_status() Max Reitz
2014-10-24 10:57 ` [Qemu-devel] [PATCH v4 1/3] raw-posix: Fix raw_co_get_block_status() after EOF Max Reitz
2014-10-24 10:57 ` [Qemu-devel] [PATCH v4 2/3] raw-posix: raw_co_get_block_status() return value Max Reitz
2014-10-24 10:58 ` [Qemu-devel] [PATCH v4 3/3] iotests: Add test for external image truncation Max Reitz
2014-10-24 14:11 ` Eric Blake
2014-10-28 14:27 ` Kevin Wolf [this message]
2014-10-29 10:01 ` [Qemu-devel] [PATCH v4 0/3] raw-posix: Fix raw_co_get_block_status() Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141028142748.GD4828@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.