From: "Pali Rohár" <pali.rohar@gmail.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] sensord: do not fail if some sensor does not return data
Date: Tue, 28 Oct 2014 14:54:50 +0000 [thread overview]
Message-ID: <201410281554.50100@pali> (raw)
[-- Attachment #1.1: Type: Text/Plain, Size: 1796 bytes --]
On Monday 09 June 2014 18:23:31 Pali Rohár wrote:
> On Saturday 17 May 2014 22:02:12 Pali Rohár wrote:
> > Hello,
> >
> > I see very annoying bug in sensord. When some hwmon driver
> > returns -EINVAL (for any reason), sensord daemon will stop
> > reading next sensors values. This means if first hwmon
> > device fail to return value, sensord daemon will not log
> > anything.
> >
> > Returning -EINVAL from kernel driver is normal (e.g. when
> > graphic card with has internal temperature sensor is turned
> > off) and sensord should not fail on this.
> >
> > Program sensors already handling this problem and will print
> > N/A if there is reading error.
> >
> > I'm sending simple patch which just report NaN value when
> > kernel report error. And also sensord will continue to
> > reading next hwmon interfaces.
> >
> > Without this patch I see only these lines logged:
> >
> > sensord: Chip: radeon-pci-0100
> > sensord: Adapter: PCI adapter
> > sensord: Error getting sensor data: radeon/#0: Can't read
> > sensord: sensor read error (-1)
> >
> > And all other sensors are ignored and nothing more is
> > logged.
> >
> > After my patch all hwmon sensors data are logged:
> >
> > sensord: Chip: radeon-pci-0100
> > sensord: Adapter: PCI adapter
> > sensord: temp1: nan C
> > sensord: Chip: i8k-virtual-0
> > sensord: Adapter: Virtual device
> > sensord: Left Fan: 2685 RPM
> > sensord: CPU: 49.0 C
> > sensord: temp2: 55.0 C
> > sensord: temp3: 39.0 C
> > sensord: Chip: coretemp-isa-0000
> > sensord: Adapter: ISA adapter
> > sensord: Physical id 0: 50.0 C
> > sensord: Core 0: 47.0 C
> > sensord: Core 1: 50.0 C
>
> BUMP!
>
> Can somebody review my patch?
PING.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next reply other threads:[~2014-10-28 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 14:54 Pali Rohár [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-09 16:23 [lm-sensors] [PATCH] sensord: do not fail if some sensor does not return data Pali Rohár
2014-05-17 20:02 Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201410281554.50100@pali \
--to=pali.rohar@gmail.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.