From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org,
Douglas Gilbert <dgilbert@interlog.com>,
Robert Elliott <Elliott@hp.com>
Subject: Re: [PATCH 1/6] scsi: refactor scsi_reset_provider handling
Date: Tue, 28 Oct 2014 18:36:07 +0100 [thread overview]
Message-ID: <20141028173607.GA22593@lst.de> (raw)
In-Reply-To: <544F5900.6080406@acm.org>
On Tue, Oct 28, 2014 at 09:51:12AM +0100, Bart Van Assche wrote:
> This function returns 0 even if an action like SG_SCSI_RESET_BUS fails (rtn
> != SUCCESS) with the flag SCSI_TRY_RESET_NO_ESCALATE set. I think the
> current behavior is to return -EIO in that case. If this change was
> intended, please mention it in the patch description.
I will fix this up for the next version, thanks for catching it!
next prev parent reply other threads:[~2014-10-28 17:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 17:59 misc scsi ioctl updates Christoph Hellwig
2014-10-27 17:59 ` [PATCH 1/6] scsi: refactor scsi_reset_provider handling Christoph Hellwig
2014-10-28 8:51 ` Bart Van Assche
2014-10-28 17:36 ` Christoph Hellwig [this message]
2014-10-27 17:59 ` [PATCH 2/6] scsi: split scsi_nonblockable_ioctl Christoph Hellwig
2014-10-28 9:05 ` Bart Van Assche
2014-10-28 17:39 ` Christoph Hellwig
2014-10-29 10:55 ` Bart Van Assche
2014-10-29 18:41 ` Christoph Hellwig
2014-10-27 17:59 ` [PATCH 3/6] sd: fix up ->compat_ioctl Christoph Hellwig
2014-10-27 17:59 ` [PATCH 4/6] st: call scsi_set_medium_removal directly Christoph Hellwig
2014-10-27 17:59 ` [PATCH 5/6] osst: " Christoph Hellwig
2014-10-27 17:59 ` [PATCH 6/6] scsi: return EAGAIN when resetting a device under EH Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2014-10-30 9:27 misc scsi ioctl updates V2 Christoph Hellwig
2014-10-30 9:27 ` [PATCH 1/6] scsi: refactor scsi_reset_provider handling Christoph Hellwig
2014-10-30 9:38 ` Hannes Reinecke
2014-11-05 14:11 ` Hannes Reinecke
2014-11-05 14:25 ` Martin K. Petersen
2014-11-06 18:01 ` Elliott, Robert (Server Storage)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141028173607.GA22593@lst.de \
--to=hch@lst.de \
--cc=Elliott@hp.com \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.