All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Jan Kara <jack@suse.cz>,
	linux-ext4@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix overflow when updating superblock backups after resize
Date: Tue, 28 Oct 2014 16:40:59 -0400	[thread overview]
Message-ID: <20141028204059.GC20378@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1410221700200.2250@localhost.localdomain>

On Wed, Oct 22, 2014 at 05:00:47PM +0200, Lukáš Czerner wrote:
> On Wed, 22 Oct 2014, Jan Kara wrote:
> > When there are no meta block groups update_backups() will compute the
> > backup block in 32-bit arithmetics thus possibly overflowing the block
> > number and corrupting the filesystem. OTOH filesystems without meta
> > block groups larger than 16 TB should be rare. Fix the problem by doing
> > the counting in 64-bit arithmetics.
> 
> Looks good, thanks.
> 
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>

Thanks, applied.

					- Ted

      reply	other threads:[~2014-10-28 20:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 14:29 [PATCH] ext4: Fix overflow when updating superblock backups after resize Jan Kara
2014-10-22 15:00 ` Lukáš Czerner
2014-10-28 20:40   ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141028204059.GC20378@thunk.org \
    --to=tytso@mit.edu \
    --cc=jack@suse.cz \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.