Re: [PATCH bluetooth-next 07/17] mac802154: remove might_sleep from driver layer

[Alexander Aring <alex.aring@gmail.com>]

Hi Varka,

On Wed, Oct 29, 2014 at 11:27:53AM +0530, Varka Bhadram wrote:
> On 10/29/2014 11:23 AM, Alexander Aring wrote:
> >Hi Varka,
> >
> >On Wed, Oct 29, 2014 at 09:03:49AM +0530, Varka Bhadram wrote:
> >>On 10/28/2014 10:51 PM, Alexander Aring wrote:
> >>>This patch removes all might_sleep calls from driver layer. This
> >>>handling is already done by mac802154 layer.
> >>>
> >>>Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> >>>---
> >>>  drivers/net/ieee802154/at86rf230.c | 3 ---
> >>>  drivers/net/ieee802154/cc2520.c    | 1 -
> >>>  drivers/net/ieee802154/fakelb.c    | 4 ----
> >>>  3 files changed, 8 deletions(-)
> >>>
> >>For CC2520 driver
> >>
> >I would Cc you here if you stand in the MAINTAINERS file for cc2520
> >driver. I asked you some months ago if you like to be there. I didn't
> >saw any patches for that. I thought it's out of interest by you that you
> >want to be maintainer for this driver.  When these changes are very trivial
> >like this one, it's okay for you when Marcel simple apply these patches
> >without any ack? I already told him that we don't need to wait of Alan's
> >ack for the mrf24j40 driver.
> >
> >Nevertheless if you want to add really a Acked here and we need to wait
> >then please insert you in the MAINTAINERS file. When I run
> >get_maintainers it's currently me who is maintainer for the cc2520 driver.
> >
> >If you want to take care of this driver, please see my improvements and
> >fixes for the at86rf230. I am sure you could also take some code for the
> >cc2520 from it. Also I would be very happy for async xmit handling or
> >regmap support. Most of the cc2520 code is lowlevel spi api calls.
> >
> >- Alex
> 
> I think i clarified you that i want to be the CC2520 driver maintainer.
> 
> I asked you to submit the patche for MAINTAINER file, you told that its
> not required.
> 

I looked up the conversion:

You:

"You mean to say that i need to add an entry in MAINTAINER file or ..?"

Me:

"not need, only if you like. I have no idea about the cc2520 driver."

need != required. For me this sentence is more... you really don't need
that do be maintainer of this if you don't like that. But if you like to
be maintainer, then send a patch.

> If i run get_maintainer on the cc2520 driver , my name is there for the commit_signer
> 

This is because get_maintainers lookups the last commits.

I run "./scripts/get_maintainer.pl -f drivers/net/ieee802154/cc2520.c"
on my own.

Output is:

Alexander Aring <alex.aring@gmail.com> (maintainer:IEEE 802.15.4 SUB...)
Grant Likely <grant.likely@linaro.org> (maintainer:OPEN FIRMWARE AND...)
Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND...)
linux-wpan@vger.kernel.org (open list:IEEE 802.15.4 SUB...)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND...)


there is no Varka here.

> I will improve this driver regmap suuport.
> 

ok.

- Alex