From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: ssb: get alp clock from devices with PMU
Date: Wed, 29 Oct 2014 09:24:43 +0000 [thread overview]
Message-ID: <20141029092443.GA9208@mwanda> (raw)
Hello Hauke Mehrtens,
The patch f924e1e989b0: "ssb: get alp clock from devices with PMU"
from Dec 5, 2012, leads to the following static checker warning:
drivers/ssb/driver_chipcommon_pmu.c:624 ssb_pmu_get_alp_clock_clk0()
warn: shift is higher precedence than mask
drivers/ssb/driver_chipcommon_pmu.c
619 static u32 ssb_pmu_get_alp_clock_clk0(struct ssb_chipcommon *cc)
620 {
621 u32 crystalfreq;
622 const struct pmu0_plltab_entry *e = NULL;
623
624 crystalfreq = chipco_read32(cc, SSB_CHIPCO_PMU_CTL) &
625 SSB_CHIPCO_PMU_CTL_XTALFREQ >> SSB_CHIPCO_PMU_CTL_XTALFREQ_SHIFT;
This was probably supposed to be:
crystalfreq = (chipco_read32(cc, SSB_CHIPCO_PMU_CTL) &
SSB_CHIPCO_PMU_CTL_XTALFREQ) >> SSB_CHIPCO_PMU_CTL_XTALFREQ_SHIFT;
626 e = pmu0_plltab_find_entry(crystalfreq);
627 BUG_ON(!e);
628 return e->freq * 1000;
629 }
regards,
dan carpenter
reply other threads:[~2014-10-29 9:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141029092443.GA9208@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.