From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs Date: Wed, 29 Oct 2014 10:01:42 +0000 Message-ID: <20141029100142.GR18557@sirena.org.uk> References: <1414411911-5539-1-git-send-email-k.kozlowski@samsung.com> <1414411911-5539-4-git-send-email-k.kozlowski@samsung.com> <20141028223121.GH18557@sirena.org.uk> <1414574413.18868.6.camel@AMDC1943> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="w0wZBAr4bXcLEtGS" Return-path: Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54866 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932168AbaJ2KDF (ORCPT ); Wed, 29 Oct 2014 06:03:05 -0400 Content-Disposition: inline In-Reply-To: <1414574413.18868.6.camel@AMDC1943> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Krzysztof Kozlowski Cc: Liam Girdwood , linux-kernel@vger.kernel.org, Ben Dooks , Kukjin Kim , Russell King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas , Chanwoo Choi --w0wZBAr4bXcLEtGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 29, 2014 at 10:20:13AM +0100, Krzysztof Kozlowski wrote: > On wto, 2014-10-28 at 22:31 +0000, Mark Brown wrote: > > This looks wrong, you're using the regular enable operation as suspend > > enable. How does that work without disrupting the current runtime > > state? > Currently it shouldn't disrupt state of regulator because during runtime > it may only be only: on (0x3) or off (0x0). Suspend enable in max77686 > writes 0x3 to the register which means - always on. > If regulator was disabled before suspend then it has to be enabled > during suspend_enable() call which is exactly what max77686_enable does. > If it was enabled then nothing happens. No, this isn't suspend enable control - this is normal, standard enable control and the device has no suspend enable control. --w0wZBAr4bXcLEtGS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUULsFAAoJECTWi3JdVIfQiuYH/iWJKED6NduyTeJ3iAPinvaV Up12xpaV2BREaXLUmKREHa9baR916FjDK0llYKsXMc834nPX1OMcQZ0qnE5ntV0h UOkzG0HeziKpXS8FPQKrRhTvmjgrD3yazQX7mtExLOFX6Hq1iEOC0IwOogrfeNYH HpyXwUUlz1xjH1BCyIF5A6T6XOfZTeC/d/azIKfTilwUOb7IkZnLRPedvQlf+nxG nA+70NoeXk5gNUFbywNp+aLkAT80Qva59FMGT/y2xyC/9I24ybLByTkOsQiRw69C HrONRFWRSXxqe7JTU6n7262RDd2BetmKeLrC7K+x4F/s067NQ50Y7srCnrkQvDY= =huVf -----END PGP SIGNATURE----- --w0wZBAr4bXcLEtGS-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Wed, 29 Oct 2014 10:01:42 +0000 Subject: [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs In-Reply-To: <1414574413.18868.6.camel@AMDC1943> References: <1414411911-5539-1-git-send-email-k.kozlowski@samsung.com> <1414411911-5539-4-git-send-email-k.kozlowski@samsung.com> <20141028223121.GH18557@sirena.org.uk> <1414574413.18868.6.camel@AMDC1943> Message-ID: <20141029100142.GR18557@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Oct 29, 2014 at 10:20:13AM +0100, Krzysztof Kozlowski wrote: > On wto, 2014-10-28 at 22:31 +0000, Mark Brown wrote: > > This looks wrong, you're using the regular enable operation as suspend > > enable. How does that work without disrupting the current runtime > > state? > Currently it shouldn't disrupt state of regulator because during runtime > it may only be only: on (0x3) or off (0x0). Suspend enable in max77686 > writes 0x3 to the register which means - always on. > If regulator was disabled before suspend then it has to be enabled > during suspend_enable() call which is exactly what max77686_enable does. > If it was enabled then nothing happens. No, this isn't suspend enable control - this is normal, standard enable control and the device has no suspend enable control. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: