From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs Date: Wed, 29 Oct 2014 10:31:40 +0000 Message-ID: <20141029103140.GY18557@sirena.org.uk> References: <1414411911-5539-1-git-send-email-k.kozlowski@samsung.com> <1414411911-5539-4-git-send-email-k.kozlowski@samsung.com> <20141028223121.GH18557@sirena.org.uk> <1414574413.18868.6.camel@AMDC1943> <20141029100142.GR18557@sirena.org.uk> <1414577934.18868.7.camel@AMDC1943> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xsYrt8mWir//dmFZ" Return-path: Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54996 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932091AbaJ2Kcc (ORCPT ); Wed, 29 Oct 2014 06:32:32 -0400 Content-Disposition: inline In-Reply-To: <1414577934.18868.7.camel@AMDC1943> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Krzysztof Kozlowski Cc: Liam Girdwood , linux-kernel@vger.kernel.org, Ben Dooks , Kukjin Kim , Russell King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas , Chanwoo Choi --xsYrt8mWir//dmFZ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 29, 2014 at 11:18:54AM +0100, Krzysztof Kozlowski wrote: > On =C5=9Bro, 2014-10-29 at 10:01 +0000, Mark Brown wrote: > > No, this isn't suspend enable control - this is normal, standard enable > > control and the device has no suspend enable control. > You mean that for such regulator the driver shouldn't implement > suspend_enable()? Yes, if there is no separate control of suspend mode in hardware then of course the driver shouldn't implement operations for things it doesn't have. --xsYrt8mWir//dmFZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUUMILAAoJECTWi3JdVIfQl34IAIU09lINYcxSvqRF0ZWXjFp/ u7O7oIGMAPbZ5KKfuiDXQB2ia0NvKEQUrZMAfDOcs7tt2ZI6y3p3Q3VM6S0Eo6ac zqEObwWNS5wo4GtIJslXDiuutFi8ww82HoWnbT6yjpUlun+fSs/Q/Vs4MQTTJVOJ ALn1Z82x0DepYtI1l1BHLCIVrVsMvFcTwPWLwAOXt7+TYQj8BfLrU2YvdDf0XhBA y8GFcu8EhW4y3ExPFJDiggNHd/i7R+NZc36pDXEbFt2J0uj9/yr0HQXBJY62+uum yQkPfRBv6znlPj5hlheHkD90y8ulYZIoEnFeLF+rq3vuI7Z5XFHxM4PRWWySikE= =B9Jq -----END PGP SIGNATURE----- --xsYrt8mWir//dmFZ-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Wed, 29 Oct 2014 10:31:40 +0000 Subject: [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs In-Reply-To: <1414577934.18868.7.camel@AMDC1943> References: <1414411911-5539-1-git-send-email-k.kozlowski@samsung.com> <1414411911-5539-4-git-send-email-k.kozlowski@samsung.com> <20141028223121.GH18557@sirena.org.uk> <1414574413.18868.6.camel@AMDC1943> <20141029100142.GR18557@sirena.org.uk> <1414577934.18868.7.camel@AMDC1943> Message-ID: <20141029103140.GY18557@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Oct 29, 2014 at 11:18:54AM +0100, Krzysztof Kozlowski wrote: > On ?ro, 2014-10-29 at 10:01 +0000, Mark Brown wrote: > > No, this isn't suspend enable control - this is normal, standard enable > > control and the device has no suspend enable control. > You mean that for such regulator the driver shouldn't implement > suspend_enable()? Yes, if there is no separate control of suspend mode in hardware then of course the driver shouldn't implement operations for things it doesn't have. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: