From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Jaroslav Kysela <perex@perex.cz>,
Clemens Ladisch <clemens@ladisch.de>,
Eduard Gilmutdinov <edgilmutdinov@gmail.com>,
Daniel Mack <zonque@gmail.com>, Vlad Catoi <vladcatoi@gmail.com>,
alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] [media] sound: simplify au0828 quirk table
Date: Thu, 30 Oct 2014 09:15:05 -0200 [thread overview]
Message-ID: <20141030091505.7d08dec8@recife.lan> (raw)
In-Reply-To: <s5hzjcd4xws.wl-tiwai@suse.de>
Em Thu, 30 Oct 2014 12:09:07 +0100
Takashi Iwai <tiwai@suse.de> escreveu:
> At Thu, 30 Oct 2014 08:53:04 -0200,
> Mauro Carvalho Chehab wrote:
> >
> > From: Mauro Carvalho Chehab <m.chehab@samsung.com>
> >
> > Add a macro to simplify au0828 quirk table. That makes easier
> > to check it against the USB IDs at drivers/media/usb/au0828-card.c
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>
> Which sign-off should I take? Judging from the author line, the
> former one?
Gah, that's the problem with rebased patches ;)
I started using mchehab@osg.samsung.com for upstream submission
a few months ago.
Both emails are valid, but I prefer if you use this one:
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> The second patch had only s-o-b from @samsung.com.
Yeah, I remembered to remove the extra SOB on the second patch,
but didn't notice it on the first one.
>
>
> thanks,
>
> Takashi
>
> >
> > diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> > index c657752a420c..5ae1d02d17a3 100644
> > --- a/sound/usb/quirks-table.h
> > +++ b/sound/usb/quirks-table.h
> > @@ -2804,133 +2804,37 @@ YAMAHA_DEVICE(0x7010, "UB99"),
> > }
> > },
> >
> > -/* Hauppauge HVR-950Q and HVR-850 */
> > -{
> > - USB_DEVICE_VENDOR_SPEC(0x2040, 0x7200),
> > - .match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> > - USB_DEVICE_ID_MATCH_INT_CLASS |
> > - USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> > - .bInterfaceClass = USB_CLASS_AUDIO,
> > - .bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
> > - .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> > - .vendor_name = "Hauppauge",
> > - .product_name = "HVR-950Q",
> > - .ifnum = QUIRK_ANY_INTERFACE,
> > - .type = QUIRK_AUDIO_ALIGN_TRANSFER,
> > - }
> > -},
> > -{
> > - USB_DEVICE_VENDOR_SPEC(0x2040, 0x7210),
> > - .match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> > - USB_DEVICE_ID_MATCH_INT_CLASS |
> > - USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> > - .bInterfaceClass = USB_CLASS_AUDIO,
> > - .bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
> > - .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> > - .vendor_name = "Hauppauge",
> > - .product_name = "HVR-950Q",
> > - .ifnum = QUIRK_ANY_INTERFACE,
> > - .type = QUIRK_AUDIO_ALIGN_TRANSFER,
> > - }
> > -},
> > -{
> > - USB_DEVICE_VENDOR_SPEC(0x2040, 0x7217),
> > - .match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> > - USB_DEVICE_ID_MATCH_INT_CLASS |
> > - USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> > - .bInterfaceClass = USB_CLASS_AUDIO,
> > - .bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
> > - .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> > - .vendor_name = "Hauppauge",
> > - .product_name = "HVR-950Q",
> > - .ifnum = QUIRK_ANY_INTERFACE,
> > - .type = QUIRK_AUDIO_ALIGN_TRANSFER,
> > - }
> > -},
> > -{
> > - USB_DEVICE_VENDOR_SPEC(0x2040, 0x721b),
> > - .match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> > - USB_DEVICE_ID_MATCH_INT_CLASS |
> > - USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> > - .bInterfaceClass = USB_CLASS_AUDIO,
> > - .bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
> > - .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> > - .vendor_name = "Hauppauge",
> > - .product_name = "HVR-950Q",
> > - .ifnum = QUIRK_ANY_INTERFACE,
> > - .type = QUIRK_AUDIO_ALIGN_TRANSFER,
> > - }
> > -},
> > -{
> > - USB_DEVICE_VENDOR_SPEC(0x2040, 0x721e),
> > - .match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> > - USB_DEVICE_ID_MATCH_INT_CLASS |
> > - USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> > - .bInterfaceClass = USB_CLASS_AUDIO,
> > - .bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
> > - .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> > - .vendor_name = "Hauppauge",
> > - .product_name = "HVR-950Q",
> > - .ifnum = QUIRK_ANY_INTERFACE,
> > - .type = QUIRK_AUDIO_ALIGN_TRANSFER,
> > - }
> > -},
> > -{
> > - USB_DEVICE_VENDOR_SPEC(0x2040, 0x721f),
> > - .match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> > - USB_DEVICE_ID_MATCH_INT_CLASS |
> > - USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> > - .bInterfaceClass = USB_CLASS_AUDIO,
> > - .bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
> > - .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> > - .vendor_name = "Hauppauge",
> > - .product_name = "HVR-950Q",
> > - .ifnum = QUIRK_ANY_INTERFACE,
> > - .type = QUIRK_AUDIO_ALIGN_TRANSFER,
> > - }
> > -},
> > -{
> > - USB_DEVICE_VENDOR_SPEC(0x2040, 0x7240),
> > - .match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> > - USB_DEVICE_ID_MATCH_INT_CLASS |
> > - USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> > - .bInterfaceClass = USB_CLASS_AUDIO,
> > - .bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
> > - .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> > - .vendor_name = "Hauppauge",
> > - .product_name = "HVR-850",
> > - .ifnum = QUIRK_ANY_INTERFACE,
> > - .type = QUIRK_AUDIO_ALIGN_TRANSFER,
> > - }
> > -},
> > -{
> > - USB_DEVICE_VENDOR_SPEC(0x2040, 0x7280),
> > - .match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> > - USB_DEVICE_ID_MATCH_INT_CLASS |
> > - USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> > - .bInterfaceClass = USB_CLASS_AUDIO,
> > - .bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
> > - .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> > - .vendor_name = "Hauppauge",
> > - .product_name = "HVR-950Q",
> > - .ifnum = QUIRK_ANY_INTERFACE,
> > - .type = QUIRK_AUDIO_ALIGN_TRANSFER,
> > - }
> > -},
> > -{
> > - USB_DEVICE_VENDOR_SPEC(0x0fd9, 0x0008),
> > - .match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> > - USB_DEVICE_ID_MATCH_INT_CLASS |
> > - USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> > - .bInterfaceClass = USB_CLASS_AUDIO,
> > - .bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
> > - .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> > - .vendor_name = "Hauppauge",
> > - .product_name = "HVR-950Q",
> > - .ifnum = QUIRK_ANY_INTERFACE,
> > - .type = QUIRK_AUDIO_ALIGN_TRANSFER,
> > - }
> > -},
> > +/*
> > + * Auvitek au0828 devices with audio interface.
> > + * This should be kept in sync with drivers/media/usb/au0828-card.c
> > + * Please notice that some drivers are DVB only, and don't need to be
> > + * here. That's the case, for example, of DVICO_FUSIONHDTV7.
> > + */
> > +
> > +#define AU0828_DEVICE(vid, pid, vname, pname) { \
> > + USB_DEVICE_VENDOR_SPEC(vid, pid), \
> > + .match_flags = USB_DEVICE_ID_MATCH_DEVICE | \
> > + USB_DEVICE_ID_MATCH_INT_CLASS | \
> > + USB_DEVICE_ID_MATCH_INT_SUBCLASS, \
> > + .bInterfaceClass = USB_CLASS_AUDIO, \
> > + .bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL, \
> > + .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) { \
> > + .vendor_name = vname, \
> > + .product_name = pname, \
> > + .ifnum = QUIRK_ANY_INTERFACE, \
> > + .type = QUIRK_AUDIO_ALIGN_TRANSFER, \
> > + } \
> > +}
> > +
> > +AU0828_DEVICE(0x2040, 0x7200, "Hauppauge", "HVR-950Q"),
> > +AU0828_DEVICE(0x2040, 0x7210, "Hauppauge", "HVR-950Q"),
> > +AU0828_DEVICE(0x2040, 0x7217, "Hauppauge", "HVR-950Q"),
> > +AU0828_DEVICE(0x2040, 0x721b, "Hauppauge", "HVR-950Q"),
> > +AU0828_DEVICE(0x2040, 0x721e, "Hauppauge", "HVR-950Q"),
> > +AU0828_DEVICE(0x2040, 0x721f, "Hauppauge", "HVR-950Q"),
> > +AU0828_DEVICE(0x2040, 0x7240, "Hauppauge", "HVR-850"),
> > +AU0828_DEVICE(0x2040, 0x7280, "Hauppauge", "HVR-950Q"),
> > +AU0828_DEVICE(0x0fd9, 0x0008, "Hauppauge", "HVR-950Q"),
> >
> > /* Digidesign Mbox */
> > {
> > --
> > 1.9.3
> >
next prev parent reply other threads:[~2014-10-30 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 10:53 [PATCH 0/2] Update Auvitek au0828 quirks Mauro Carvalho Chehab
2014-10-30 10:53 ` [PATCH 1/2] [media] sound: simplify au0828 quirk table Mauro Carvalho Chehab
2014-10-30 11:09 ` Takashi Iwai
2014-10-30 11:15 ` Mauro Carvalho Chehab [this message]
2014-10-30 11:16 ` [alsa-devel] " Clemens Ladisch
2014-10-30 11:28 ` Mauro Carvalho Chehab
2014-10-30 10:53 ` [PATCH 2/2] [media] sound: Update au0828 quirks table Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030091505.7d08dec8@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=edgilmutdinov@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mchehab@infradead.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=vladcatoi@gmail.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.