From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Clemens Ladisch <clemens@ladisch.de>,
Daniel Mack <zonque@gmail.com>,
Eduard Gilmutdinov <edgilmutdinov@gmail.com>,
Vlad Catoi <vladcatoi@gmail.com>,
alsa-devel@alsa-project.org, stable@vger.kernel.org,
Michael Krufky <mkrufky@linuxtv.org>
Subject: Re: [PATCH v2 2/2] [media] sound: Update au0828 quirks table
Date: Thu, 30 Oct 2014 11:37:25 -0200 [thread overview]
Message-ID: <20141030113725.08b3aa40@recife.lan> (raw)
In-Reply-To: <CAGoCfizkcdU1fgfLjFHwnH34HgpJBcznO+3RrqOMHpLUYKCNPg@mail.gmail.com>
Hi Devin,
Em Thu, 30 Oct 2014 09:15:31 -0400
Devin Heitmueller <dheitmueller@kernellabs.com> escreveu:
> Hi Mauro,
>
> > Syncronize it and put them on the same order as found at au0828
> > driver, as all the au0828 devices with analog TV need the
> > same quirks.
>
> The MXL and Woodbury boards don't support analog under Linux, so
> probably shouldn't be included in the list of quirks.
True.
>
> That said, the MXL and Woodbury versions of the PCBs were prototypes
> that never made it into production (and since the Auvitek chips are
> EOL, they never will). I wouldn't object to a patch which removed the
> board profiles entirely in the interest of removing dead code.
>
> It was certainly nice of Mike Krufky to work to get support into the
> open source driver before the product was released, but after four
> years it probably makes sense to remove the entries for products that
> never actually shipped.
Yeah, if nobody is using such devices, then we should get rid of them,
but I prefer to have this on a separate patch, in order to give
people the opportunity to complain.
So, if I'm understanding well, you're suggesting to add a patch
removing those 5 entries (and the corresponding quirks on alsa),
right?
{ USB_DEVICE(0x2040, 0x7201),
.driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
{ USB_DEVICE(0x2040, 0x7211),
.driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
{ USB_DEVICE(0x2040, 0x7281),
.driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
{ USB_DEVICE(0x05e1, 0x0480),
.driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY },
{ USB_DEVICE(0x2040, 0x8200),
.driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY },
{ USB_DEVICE(0x2040, 0x7260),
Regards,
Mauro
next prev parent reply other threads:[~2014-10-30 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 11:28 [PATCH v2 0/2] Update Auvitek au0828 quirks Mauro Carvalho Chehab
2014-10-30 11:28 ` [PATCH v2 1/2] [media] sound: simplify au0828 quirk table Mauro Carvalho Chehab
2014-10-30 11:28 ` [PATCH v2 2/2] [media] sound: Update au0828 quirks table Mauro Carvalho Chehab
2014-10-30 13:15 ` Devin Heitmueller
2014-10-30 13:37 ` Mauro Carvalho Chehab [this message]
2014-10-30 14:13 ` Devin Heitmueller
2014-10-30 19:52 ` Michael Ira Krufky
2014-10-30 19:55 ` Michael Ira Krufky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030113725.08b3aa40@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=dheitmueller@kernellabs.com \
--cc=edgilmutdinov@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mkrufky@linuxtv.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=vladcatoi@gmail.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.