From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Bail out from make_indexed_dir() on first error
Date: Thu, 30 Oct 2014 10:24:05 -0400 [thread overview]
Message-ID: <20141030142405.GA31927@thunk.org> (raw)
In-Reply-To: <1414077533-2133-1-git-send-email-jack@suse.cz>
On Thu, Oct 23, 2014 at 05:18:53PM +0200, Jan Kara wrote:
> When ext4_handle_dirty_dx_node() or ext4_handle_dirty_dirent_node()
> fail, there's really something wrong with the fs and there's no point in
> continuing further. Just return error from make_indexed_dir() in that
> case. Also initialize frames array so that if we return early due to
> error, dx_release() doesn't try to dereference uninitialized memory
> (which could happen also due to error in do_split()).
>
> Coverity-id: 741300
> Signed-off-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2014-10-30 14:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 15:18 [PATCH] ext4: Bail out from make_indexed_dir() on first error Jan Kara
2014-10-30 14:24 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030142405.GA31927@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.