From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v3 01/12] clk: tegra: Implement memory-controller clock Date: Thu, 30 Oct 2014 15:57:46 +0100 Message-ID: <20141030145744.GE20072@ulmo.nvidia.com> References: <1413196434-5292-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wTWi5aaYRw9ix9vO" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tomeu Vizoso Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Joerg Roedel , Stephen Warren , Alexandre Courbot , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Mike Turquette , Peter De Schrijver , Prashant Gaikwad List-Id: iommu@lists.linux-foundation.org --wTWi5aaYRw9ix9vO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 20, 2014 at 01:02:45PM +0200, Tomeu Vizoso wrote: > On 13 October 2014 12:33, Thierry Reding wrote: [...] > > +struct clk *tegra_clk_register_mc(const char *name, const char *parent= _name, > > + void __iomem *reg, spinlock_t *lock) > > +{ > > + return clk_register_divider_table(NULL, "mc", "emc_mux", 0, reg, >=20 > Should take name and parent_name from the passed args? >=20 > With that change: >=20 > Reviewed-By: Tomeu Vizoso Good catch. Thanks, Thierry --wTWi5aaYRw9ix9vO Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUUlHoAAoJEN0jrNd/PrOh9hgQAIAhXLhqxEgA//P81a0CFRNT qQUyaAPdtcamysQ6QAhQMdKGLOQCz6Iuc82jDn0diUzhqT5dAGFHZDJzG4Fg7991 xZZH9UOJr2I66gZQJTSLKEEuY0I2ZOii0ZASypfemtLGbYwJD27mpiXebvUDPpyZ xKaRHkPayoG1kId81an6yB3x0jiIRPJDt9ROCZZWeXVf8NN0/8szkbgNxm5hKmCs kqMoG5OzYGAifJmbIUs1YY9xpApKJc076Ezl0qTX0GpXk2Qnr4k+9ye3Rt2fWaqF I9/0/ckmugrhYTTrNBe5kmWOq7dsAtyb6dbP+E6VOPzgDS8fCkkLXE8S4y6z76Cv s2E9NnjA4wii4SfEWA4PQH1n3BEtiBIFZXuf4l8KYt7OQIgvxGvOh5SYTwD8omNQ Ye6b5af86uLDZ/BsTuTnga2Pqq4gB26N4dBPWJBMuVsduki/tyK4Bo3v43l/F/51 fuJMap7QoiaGVqzLq4gDspBsjeZgXS3DEMB3ne5JRWSlbwPsgBCeQ3kADEESufDD AHfnuiJJUc0klwgY5gwuwY2jlGOySA0nnnLky9OrM1NA1DknAFNTs1epQ5pR+g0G zRCPs2R9nBKJ2VTPiVP/0IoxckIjLmXG+HYfCmIsswrDgZU3qzoG76/3hTfqmpj+ M5O6IoE1DELDNoPH4W/4 =wOJF -----END PGP SIGNATURE----- --wTWi5aaYRw9ix9vO-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@gmail.com (Thierry Reding) Date: Thu, 30 Oct 2014 15:57:46 +0100 Subject: [PATCH v3 01/12] clk: tegra: Implement memory-controller clock In-Reply-To: References: <1413196434-5292-1-git-send-email-thierry.reding@gmail.com> Message-ID: <20141030145744.GE20072@ulmo.nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Oct 20, 2014 at 01:02:45PM +0200, Tomeu Vizoso wrote: > On 13 October 2014 12:33, Thierry Reding wrote: [...] > > +struct clk *tegra_clk_register_mc(const char *name, const char *parent_name, > > + void __iomem *reg, spinlock_t *lock) > > +{ > > + return clk_register_divider_table(NULL, "mc", "emc_mux", 0, reg, > > Should take name and parent_name from the passed args? > > With that change: > > Reviewed-By: Tomeu Vizoso Good catch. Thanks, Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: