From: Pavel Machek <pavel@ucw.cz>
To: Tina Ruchandani <ruchandani.tina@gmail.com>
Cc: len.brown@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, arnd@arndb.de,
opw-kernel@googlegroups.com, rjw@rjwysocki.net
Subject: Re: [PATCH] PM / Hibernate: Migrate to ktime_t
Date: Thu, 30 Oct 2014 19:18:29 +0100 [thread overview]
Message-ID: <20141030181829.GB14412@amd> (raw)
In-Reply-To: <20141030180453.GA55907@localhost>
On Thu 2014-10-30 11:04:53, Tina Ruchandani wrote:
> This patch migrates swsusp_show_speed and its callers to using ktime_t instead
> of 'struct timeval' which suffers from the y2038 problem.
>
> Changes to swsusp_show_speed:
> - use ktime_t for start and stop times
> - pass start and stop times by value
> Calling functions affected:
> - load_image
> - load_image_lzo
> - save_image
> - save_image_lzo
> - hibernate_preallocate_memory
> Design decisions:
> - use ktime_t to preserve same granularity of reporting as before
> - use centisecs logic as before to avoid 'div by zero' issues caused by
> using seconds and nanoseconds directly
> - use monotonic time (ktime_get()) since we only care about elapsed time.
>
> Signed-off-by: Tina Ruchandani <ruchandani.tina@gmail.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-10-30 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 18:04 [PATCH] PM / Hibernate: Migrate to ktime_t Tina Ruchandani
2014-10-30 18:18 ` Pavel Machek [this message]
2014-10-30 19:08 ` Arnd Bergmann
2014-11-08 1:47 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030181829.GB14412@amd \
--to=pavel@ucw.cz \
--cc=arnd@arndb.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=opw-kernel@googlegroups.com \
--cc=rjw@rjwysocki.net \
--cc=ruchandani.tina@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.