Re: [PATCH 7/9] ASoC: Intel: move PCI probe to a seprate file

[Vinod Koul <vinod.koul@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1495 bytes --]

On Thu, Oct 30, 2014 at 05:31:12PM +0000, Mark Brown wrote:
> On Thu, Oct 30, 2014 at 06:07:00PM +0100, Takashi Iwai wrote:
> > Vinod Koul wrote:
> 
> > > snd-intel-sst-pci-y += sst-intel-core.o sst_pci.o
> > > snd-intel-sst-acpi-y += st-intel-core.o sst_acpi.o
> 
> > Kbuild doesn't allow this syntax, AFAIK.
> 
> I've not followed the whole discussion but why not just have the core
> code as a separate module, this seems like an awful lot of trouble for
> something that's normally straightforward...
Hmm seems like my attempt to have just two module is fraught with risks. I
will convert core to module which can be linked either by PCI or ACPI.

Thats should clean this out :)
Thanks for all the points

Mark, please drop this patch, the ones before will still be required for
module so pls do review them

Thanks
-- 
~Vinod

> 
> > > well both can be compile tested and we will put in symbols about limitation
> > > of having bpth apci and pci as built-in or module.
> 
> > No, the point is that the exclusiveness in Kconfig level gives more
> > demerits.  This makes impossible to build the both codes in a single
> > shot, which makes also impossible to cover wider build tests, etc.
> > My concern isn't about the actual operation but about testing.
> 
> > That is: don't try to side step such a build issue.  I bet it'll
> > strike back later.  Better to keep rather the simple and common
> > approach other drivers take.
> 
> Right.



-- 

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]