From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lists.s-osg.org ([54.187.51.154]:42782 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756393AbaJaKdE (ORCPT ); Fri, 31 Oct 2014 06:33:04 -0400 Date: Fri, 31 Oct 2014 08:32:58 -0200 From: Mauro Carvalho Chehab To: Matthias Schwarzott Cc: crope@iki.fi, linux-media@vger.kernel.org Subject: Re: [PATCH] cx231xx: remove direct register PWR_CTL_EN modification that switches port3 Message-ID: <20141031083258.4cfd463a@recife.lan> In-Reply-To: <1414709035-7729-1-git-send-email-zzam@gentoo.org> References: <20141030182706.09265d37@recife.lan> <1414709035-7729-1-git-send-email-zzam@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Thu, 30 Oct 2014 23:43:55 +0100 Matthias Schwarzott escreveu: > The only remaining place that modifies the relevant bit is in function > cx231xx_set_Colibri_For_LowIF > > Signed-off-by: Matthias Schwarzott > --- > drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c > index b56bc87..781908b 100644 > --- a/drivers/media/usb/cx231xx/cx231xx-avcore.c > +++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c > @@ -2270,7 +2270,6 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode) > case POLARIS_AVMODE_ANALOGT_TV: > > tmp |= PWR_DEMOD_EN; > - tmp |= (I2C_DEMOD_EN); > value[0] = (u8) tmp; > value[1] = (u8) (tmp >> 8); > value[2] = (u8) (tmp >> 16); > @@ -2366,7 +2365,7 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode) > } > > tmp &= (~PWR_AV_MODE); > - tmp |= POLARIS_AVMODE_DIGITAL | I2C_DEMOD_EN; > + tmp |= POLARIS_AVMODE_DIGITAL; > value[0] = (u8) tmp; > value[1] = (u8) (tmp >> 8); > value[2] = (u8) (tmp >> 16); Hmm... Not sure if this patch is right. There is one I2C bus internally at cx231xx. Some configurations need to go through this I2C bus. Did you test if changing from/to analog/digital mode is working? Regards, Mauro