From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors Date: Fri, 31 Oct 2014 14:41:14 +0100 Message-ID: <20141031134114.GD32139@lunn.ch> References: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Mika Westerberg Cc: "Rafael J. Wysocki" , Linus Walleij , Alexandre Courbot , Bryan Wu , Richard Purdie , Ben Dooks , Kukjin Kim , Jason Cooper , Andrew Lunn , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Fri, Oct 31, 2014 at 01:40:58PM +0200, Mika Westerberg wrote: > Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO > descriptors") already converted most of the driver to use GPIO descriptors. > What is still missing is the platform specific hook gpio_blink_set() and > board files which pass legacy GPIO numbers to this driver in platform data. > > In this patch we handle the former and convert gpio_blink_set() to take > GPIO descriptor instead. In order to do this we convert the existing four > users to accept GPIO descriptor and translate it to legacy GPIO number in > the platform code. This effectively "pushes" legacy GPIO number usage from > the driver to platforms. > > Also add comment to the remaining block describing that it is legacy code > path and we are getting rid of it eventually. > > Suggested-by: Linus Walleij > Signed-off-by: Mika Westerberg Hi Mika For the plat-orion parts: Acked-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Fri, 31 Oct 2014 14:41:14 +0100 Subject: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors In-Reply-To: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com> References: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com> Message-ID: <20141031134114.GD32139@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Oct 31, 2014 at 01:40:58PM +0200, Mika Westerberg wrote: > Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO > descriptors") already converted most of the driver to use GPIO descriptors. > What is still missing is the platform specific hook gpio_blink_set() and > board files which pass legacy GPIO numbers to this driver in platform data. > > In this patch we handle the former and convert gpio_blink_set() to take > GPIO descriptor instead. In order to do this we convert the existing four > users to accept GPIO descriptor and translate it to legacy GPIO number in > the platform code. This effectively "pushes" legacy GPIO number usage from > the driver to platforms. > > Also add comment to the remaining block describing that it is legacy code > path and we are getting rid of it eventually. > > Suggested-by: Linus Walleij > Signed-off-by: Mika Westerberg Hi Mika For the plat-orion parts: Acked-by: Andrew Lunn Andrew