From: Will Deacon <will.deacon@arm.com>
To: Weston Andros Adamson <dros@primarydata.com>
Cc: Peng Tao <tao.peng@primarydata.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
linux-nfs list <linux-nfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: WARNING at fs/nfs/write.c:743 nfs_inode_remove_request with -rc6
Date: Fri, 31 Oct 2014 14:55:28 +0000 [thread overview]
Message-ID: <20141031145528.GI6731@arm.com> (raw)
In-Reply-To: <FE0552AE-5243-44D3-B661-B622C2D957C0@primarydata.com>
On Fri, Oct 31, 2014 at 02:49:13PM +0000, Weston Andros Adamson wrote:
> On Oct 20, 2014, at 9:57 AM, Will Deacon <will.deacon@arm.com> wrote:
> > On Sat, Oct 11, 2014 at 02:32:29PM +0100, Weston Andros Adamson wrote:
> >> I’ve been very busy, but I haven’t forgotten about your bug report!
> >
> > No problem, I've been busy too. I just checked with -rc1 and I can reproduce
> > the issue there too.
> >
> >> I think the WARN_ON_ONCE is just wrong, there are cases where the
> >> PG_INODE_REF flag is legitimately not set. The flag is set so that sub
> >> requests can mimmic the parent request’s reference count.
> >>
> >> Could you please run the reproducer again, unmount, then check the contents of
> >> /proc/fs/nfsfs/servers?
> >
> > Sure. I just tried this and that file is empty after unmounting.
>
> Sorry for the delay (again) - I just got back from a two week holiday.
>
> This is good news! I think we can safely remove this WARN_ON_ONCE and call it a
> day… or maybe calling it a month is more accurate ;)
Great! Feel free to add my reported-by/tested-by on that patch.
Will
prev parent reply other threads:[~2014-10-31 14:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 13:03 WARNING at fs/nfs/write.c:743 nfs_inode_remove_request with -rc6 Will Deacon
2014-09-23 13:33 ` Weston Andros Adamson
2014-09-23 13:59 ` Will Deacon
2014-09-23 14:53 ` Will Deacon
2014-09-23 14:59 ` Weston Andros Adamson
2014-09-23 15:02 ` Weston Andros Adamson
2014-09-23 15:08 ` Weston Andros Adamson
2014-09-23 15:25 ` Will Deacon
2014-09-25 17:15 ` Will Deacon
2014-09-25 17:27 ` Weston Andros Adamson
2014-10-11 13:32 ` Weston Andros Adamson
2014-10-20 13:57 ` Will Deacon
2014-10-31 14:49 ` Weston Andros Adamson
2014-10-31 14:55 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141031145528.GI6731@arm.com \
--to=will.deacon@arm.com \
--cc=dros@primarydata.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tao.peng@primarydata.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.