From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 1/3] Input: altera_ps2 - write to correct register when disabling interrupts
Date: Fri, 31 Oct 2014 09:52:55 -0700 [thread overview]
Message-ID: <20141031165255.GD32331@dtor-ws> (raw)
In-Reply-To: <1414759291-23164-1-git-send-email-tklauser@distanz.ch>
On Fri, Oct 31, 2014 at 01:41:29PM +0100, Tobias Klauser wrote:
> In altera_ps2_close, the data register (offset 0) is written instead of
> the control register (offset 4), leading to the RX interrupt not being
> disabled. Fix this by calling writel() with the offset for the proper
> register.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied the first 2 and queued 3rd for 3.19. Thanks Tobias.
> ---
> drivers/input/serio/altera_ps2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/altera_ps2.c b/drivers/input/serio/altera_ps2.c
> index cce69d6..e0371e1 100644
> --- a/drivers/input/serio/altera_ps2.c
> +++ b/drivers/input/serio/altera_ps2.c
> @@ -74,7 +74,7 @@ static void altera_ps2_close(struct serio *io)
> {
> struct ps2if *ps2if = io->port_data;
>
> - writel(0, ps2if->base); /* disable rx irq */
> + writel(0, ps2if->base + 4); /* disable rx irq */
> }
>
> /*
> --
> 2.0.1
>
>
--
Dmitry
prev parent reply other threads:[~2014-10-31 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 12:41 [PATCH 1/3] Input: altera_ps2 - write to correct register when disabling interrupts Tobias Klauser
2014-10-31 16:52 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141031165255.GD32331@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.