All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Martin Belanger
	<martin.belanger-Ir6+u9MVKBtBDgjK7y7TUQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>,
	Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Subject: Re: Problem with multiple i2c multiplexers on the same bus
Date: Fri, 31 Oct 2014 22:03:02 +0100	[thread overview]
Message-ID: <20141031210301.GA4169@katana> (raw)
In-Reply-To: <CAB0SmAFZ5KPpeSbQia9kq668G5kE6hpw9eBRy=59U6GOymkj9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1734 bytes --]

Hi,

On Mon, Oct 27, 2014 at 11:46:01AM -0700, Martin Belanger wrote:
> This is regarding a series of emails between Guenter Roeck and Jean
> Delvare titled "Problem with multiple i2c multiplexers on one bus, and
> mux bus naming" sent in November 2013. Ref:
> http://thread.gmane.org/gmane.linux.drivers.i2c/16980

Please CC those people then, too. That helps getting their attention.
I've done this now.

> I'm having the same problem with multiple PCA954x multiplexers on the
> same bus and there is no way to tell them apart just by looking at the
> "name" file.
> 
> There was a suggestion to change the name from "i2c-N-mux (chan_id M)"
> to "i2c-N-mux-XX (chan_id M)" or even "i2c-N-mux-i2c-XX (chan_id M)",
> where XX is the multiplexer's i2c address. That would solve my
> problem, but unfortunately it looks like Guenter never submitted the
> patch (or maybe it was rejected?).

It just dropped off :( But you guys have my attention now, let's fix
this issue for 3.19! I am just reading through the old mails and will
think about it. Input is welcome.

> I would like to submit a similar change, but I was thinking of adding
> a module parameter so that the change is not the default behavior.
> The idea is to preserve backward compatibility for applications that
> don't require this fix. For example, modprobe i2c-dev
> explicit_mux_id=1 would use i2c-N-mux-i2c-XX (chan_id M), whereas
> modprobe i2c-dev would default to the current behavior: i.e. i2c-N-mux
> (chan_id M).

I don't like the need to set a module parameter to fix a flaw. I do
consider changing the ABI to have better strings in "name". But as said,
I need to think about it a little more...

Thanks,

   Wolfram


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2014-10-31 21:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-27 18:46 Problem with multiple i2c multiplexers on the same bus Martin Belanger
     [not found] ` <CAB0SmAFZ5KPpeSbQia9kq668G5kE6hpw9eBRy=59U6GOymkj9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-31 21:03   ` Wolfram Sang [this message]
2014-10-31 21:17     ` Guenter Roeck
     [not found]       ` <5453FC86.1080408-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-10-31 21:45         ` Martin Belanger
     [not found]           ` <CAB0SmAG1r-EUFrDAjuh14uYQYc_typV4+JbfkUvCGX+=_09QmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-31 21:59             ` Guenter Roeck
2014-10-31 21:59             ` Wolfram Sang
2014-11-02 20:38               ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141031210301.GA4169@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=jdelvare-l3A5Bk7waGM@public.gmane.org \
    --cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=martin.belanger-Ir6+u9MVKBtBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.