From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Akihiro TSUKADA <tskd08@gmail.com>
Cc: Gregor Jasny <gjasny@googlemail.com>, linux-media@vger.kernel.org
Subject: Re: [git:v4l-utils/master] libdvbv5, dvbv5-scan: generalize channel duplication check
Date: Sun, 2 Nov 2014 07:41:53 -0200 [thread overview]
Message-ID: <20141102074153.7cbad706@recife.lan> (raw)
In-Reply-To: <5455F9C6.4070002@gmail.com>
Em Sun, 02 Nov 2014 18:30:46 +0900
Akihiro TSUKADA <tskd08@gmail.com> escreveu:
> Hi,
>
> After I re-checked the source,
> I noticed that dvb_scan_add_entry() also breaks API/ABI compatibility
> as well as dvb_new_freq_is_needed(), and those functions are
> marked as "ancillary functions used internally inside the library"
> in dvb-scan.h.
> So I think it would rather be better to move those funcs to a private
> header (dvb-scan-priv.h?).
> Which way should we go? ver bump/compat-soname.c/dvb-scan-priv.h ?
I would keep them exported. It shouldn't be hard to provide a backward
compatible function with the same name where the extra parameter would
be filled internally, and passed to a new function with one extra argument.
Regards,
Mauro
next prev parent reply other threads:[~2014-11-02 9:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1XkI3i-00082l-Jd@www.linuxtv.org>
[not found] ` <54556AC9.40309@googlemail.com>
2014-11-02 9:30 ` [git:v4l-utils/master] libdvbv5, dvbv5-scan: generalize channel duplication check Akihiro TSUKADA
2014-11-02 9:41 ` Mauro Carvalho Chehab [this message]
2014-11-02 10:18 ` Gregor Jasny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141102074153.7cbad706@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=gjasny@googlemail.com \
--cc=linux-media@vger.kernel.org \
--cc=tskd08@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.