From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl6aq-00021P-Qx for qemu-devel@nongnu.org; Sun, 02 Nov 2014 20:38:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xl6ak-0003tZ-KT for qemu-devel@nongnu.org; Sun, 02 Nov 2014 20:38:04 -0500 Received: from ozlabs.org ([103.22.144.67]:50809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xl6ak-0003tD-8j for qemu-devel@nongnu.org; Sun, 02 Nov 2014 20:37:58 -0500 Date: Mon, 3 Nov 2014 12:02:20 +1100 From: David Gibson Message-ID: <20141103010220.GB1561@voom.redhat.com> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-3-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TakKZr9L6Hm6aLOc" Content-Disposition: inline In-Reply-To: <1412358473-31398-3-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 02/47] Tests: QEMUSizedBuffer/QEMUBuffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com --TakKZr9L6Hm6aLOc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 03, 2014 at 06:47:08PM +0100, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" >=20 > * Please comment on separate thread for this QEMUSziedBuffer patch * >=20 > Modify some of tests/test-vmstate.c to use the in memory file based > on QEMUSizedBuffer to provide basic testing of QEMUSizedBuffer and > the associated memory backed QEMUFile type. >=20 > Only some of the tests are changed so that the fd backed QEMUFile is > still tested. >=20 > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Eric Blake Reviewed-by: David Gibson Looks ok, although I do wonder if the removal of some of the test paths for regular files is a concern. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --TakKZr9L6Hm6aLOc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUVtQcAAoJEGw4ysog2bOSN74QAM8COn1yomOKDz0NX6D5ZcGa kUGjbmdfTroawIxiQCGFJ5roMqrxgbSRnxO5ypC9VAxDcdnehHJqUoQV9UuoLgw9 8lO644UTAMjoN40c8k2YpA+Ksc4rpYPwnMDTHQhBTNnEqVd4rhYkrJabjnPlP/YC BVRUB76A3AvyWOrGYkLa97jpoA+sk8AjlOVHa8xvGZbJFu8wJPf4EtsMEkH20YpK 8BsnGt7eJkK7/Xkp3GcWmaw9DUQyfoEAYrblmx4mLvczb9hF0TpCkSuF+ExMzFTT qDdu2JTLGZEGLAehni4fQVwqTM/CrJnViZojQw1L3XG0SxBPoGj2coRN+/UUHA/C JOhisU6JAyZqmxA60fzIAV/uYFqWSe4dm9udJIT5jwkOoYio67N4JT18S1ujYmuJ WrFlJIkMb9cZpNNUy9twaFeeFJ+Ld+DdjD3UlrWJOOS0l8Oor3jb7PUh3KuJq56u pkp8emHMcNMDR0spM6pgOYFRdehjs1UNgP70PIMQkUq7txYz4FULoJd5XUa1ab/d Md056L8d254sx7cdHIM20JxZu2fN4VNyenVyAdg9eup2UGqjPat+ZaS/1CvbtLxr SwCIBAV7T2Co8+EDAFW5kICnwB/EzRYp3ldK4/eeivplrX7bNUsPqHYzidTbeqGZ Y3cUHgxKCmRKc4Be8kxA =szIC -----END PGP SIGNATURE----- --TakKZr9L6Hm6aLOc--