From: Christoph Hellwig <hch@infradead.org>
To: Meelis Roos <mroos@linux.ee>
Cc: linux-scsi@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: blk-mq problem on proliant DL380 G3 (cciss)
Date: Mon, 3 Nov 2014 02:08:16 -0800 [thread overview]
Message-ID: <20141103100816.GA16752@infradead.org> (raw)
In-Reply-To: <alpine.LRH.2.11.1410291233090.12885@adalberg.ut.ee>
Meelis,
can you give the patch below a try? This only tries to locked the door
on devices that actually were reset. Given that on a reset device we
fail all commands before resuming operations it should work fine there
as all tags should be released.
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index fa7b5ec..7af43cb 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -2016,8 +2016,10 @@ static void scsi_restart_operations(struct Scsi_Host *shost)
* is no point trying to lock the door of an off-line device.
*/
shost_for_each_device(sdev, shost) {
- if (scsi_device_online(sdev) && sdev->locked)
+ if (scsi_device_online(sdev) && sdev->was_reset && sdev->locked) {
scsi_eh_lock_door(sdev);
+ sdev->was_reset = 0;
+ }
}
/*
next prev parent reply other threads:[~2014-11-03 10:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 10:47 blk-mq problem on proliant DL380 G3 (cciss) Meelis Roos
2014-10-29 11:46 ` Meelis Roos
2014-10-29 15:08 ` Jens Axboe
2014-10-29 15:38 ` Meelis Roos
2014-10-29 22:50 ` Elliott, Robert (Server Storage)
2014-10-29 18:38 ` Christoph Hellwig
2014-10-29 20:06 ` Meelis Roos
2014-10-29 20:13 ` Jens Axboe
2014-10-30 5:46 ` Meelis Roos
2014-10-30 11:18 ` Meelis Roos
2014-10-30 15:19 ` Christoph Hellwig
2014-10-30 17:32 ` Meelis Roos
2014-10-30 17:45 ` Christoph Hellwig
2014-11-03 1:23 ` Jens Axboe
2014-11-03 10:08 ` Christoph Hellwig [this message]
2014-11-03 13:05 ` Meelis Roos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103100816.GA16752@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-scsi@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.