From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
shuang.he@linux.intel.com, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v2 09/18] drm/i915/audio: remove misleading checks for !eld[0]
Date: Mon, 3 Nov 2014 13:04:41 +0100 [thread overview]
Message-ID: <20141103120441.GR26941@phenom.ffwll.local> (raw)
In-Reply-To: <CABVU7+vojOTFKmvbPxLBobgQk9V1bHWebNFv8emyXtX21uCm_g@mail.gmail.com>
On Mon, Oct 27, 2014 at 11:27:18AM -0700, Rodrigo Vivi wrote:
> I'm not 100% convinced drm_select_eld will always cover this check... so
> What do you think about changing it to a BUG_ON or at least a WARN_ON?
Please don't kill the driver with a BUG_ON, always use WARN_ON instead.
Except when the oops will happen anyway and can't be recovered.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-03 12:04 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 14:26 [PATCH v2 00/18] drm/i915: hdmi/dp audio rework Jani Nikula
2014-10-27 14:26 ` [PATCH v2 01/18] drm/i915: add new intel audio file to group DP/HDMI audio Jani Nikula
2014-10-27 17:40 ` Vivi, Rodrigo
2014-10-27 14:26 ` [PATCH v2 02/18] drm/i915/audio: constify hdmi audio clock struct Jani Nikula
2014-10-27 17:42 ` Rodrigo Vivi
2014-10-27 14:26 ` [PATCH v2 03/18] drm/i915/audio: beat some sense into the variable types and names Jani Nikula
2014-10-27 17:46 ` Rodrigo Vivi
2014-10-27 14:26 ` [PATCH v2 04/18] drm/i915: pass intel_encoder to intel_write_eld Jani Nikula
2014-10-27 17:47 ` Rodrigo Vivi
2014-10-27 14:26 ` [PATCH v2 05/18] drm/i915/audio: pass intel_encoder on to platform specific ELD functions Jani Nikula
2014-10-27 17:52 ` Rodrigo Vivi
2014-10-28 7:30 ` Daniel Vetter
2014-10-29 21:48 ` Rodrigo Vivi
2014-10-30 8:52 ` Jani Nikula
2014-11-03 11:59 ` Daniel Vetter
2014-11-04 23:18 ` Rodrigo Vivi
2014-10-27 14:26 ` [PATCH v2 06/18] drm/i915/audio: set ELD Conn_Type at one place Jani Nikula
2014-10-27 18:00 ` Rodrigo Vivi
2014-10-28 9:18 ` Jani Nikula
2014-10-28 11:53 ` [PATCH v3] " Jani Nikula
2014-10-28 16:23 ` Rodrigo Vivi
2014-10-27 14:26 ` [PATCH v2 07/18] drm/i915/ddi: write ELD where it's supposed to be done Jani Nikula
2014-10-27 18:04 ` Rodrigo Vivi
2014-10-28 8:28 ` Jani Nikula
2014-10-30 17:16 ` Rodrigo Vivi
2014-10-27 14:26 ` [PATCH v2 08/18] drm/i915: introduce intel_audio_codec_{enable, disable} Jani Nikula
2014-10-27 18:21 ` Rodrigo Vivi
2014-10-27 14:26 ` [PATCH v2 09/18] drm/i915/audio: remove misleading checks for !eld[0] Jani Nikula
2014-10-27 18:27 ` Rodrigo Vivi
2014-10-27 18:29 ` Rodrigo Vivi
2014-11-03 12:04 ` Daniel Vetter [this message]
2014-10-27 14:26 ` [PATCH v2 10/18] drm/i915: clean up and clarify audio related register defines Jani Nikula
2014-10-27 18:31 ` Rodrigo Vivi
2014-10-27 14:26 ` [PATCH v2 11/18] drm/i915: rewrite hsw/bdw audio codec enable/disable sequences Jani Nikula
2014-10-27 18:35 ` Rodrigo Vivi
2014-10-28 15:18 ` Jani Nikula
2014-10-28 12:03 ` [PATCH v3] " Jani Nikula
2014-10-29 21:49 ` Rodrigo Vivi
2014-10-30 8:51 ` Jani Nikula
2014-10-30 17:54 ` Rodrigo Vivi
2014-10-31 9:12 ` Jani Nikula
2014-11-03 12:09 ` Daniel Vetter
2014-11-04 8:30 ` [PATCH v4] " Jani Nikula
2014-11-04 23:15 ` Rodrigo Vivi
2014-10-27 14:26 ` [PATCH v2 12/18] drm/i915/audio: rewrite vlv/chv and gen 5-7 audio codec enable sequence Jani Nikula
2014-10-28 12:04 ` [PATCH v3] " Jani Nikula
2014-10-30 18:04 ` Rodrigo Vivi
2014-10-31 9:17 ` Jani Nikula
2014-11-04 8:31 ` [PATCH v4] " Jani Nikula
2014-11-05 9:25 ` Daniel Vetter
[not found] ` <CABVU7+uFMsMDa5mnXmDmQzGOYq5ict_aTLROXjyz8v4qOJrEog@mail.gmail.com>
2014-11-05 10:41 ` Jani Nikula
2014-11-05 12:31 ` Daniel Vetter
2014-10-27 14:26 ` [PATCH v2 13/18] drm/i915/audio: add vlv/chv/gen5-7 audio codec disable sequence Jani Nikula
2014-10-30 18:59 ` Rodrigo Vivi
2014-10-27 14:26 ` [PATCH v2 14/18] drm/i915: enable audio codec after port Jani Nikula
2014-10-30 19:03 ` Rodrigo Vivi
2014-10-27 14:26 ` [PATCH v2 15/18] drm/i915/audio: add audio codec disable on g4x Jani Nikula
2014-10-30 19:10 ` Rodrigo Vivi
2014-10-27 14:26 ` [PATCH v2 16/18] drm/i915/audio: add audio codec enable debug log for g4x Jani Nikula
2014-10-27 18:37 ` Rodrigo Vivi
2014-10-27 14:26 ` [PATCH v2 17/18] drm/i915: make pipe/port based audio valid accessors easier to use Jani Nikula
2014-10-27 18:39 ` Rodrigo Vivi
2014-10-27 14:27 ` [PATCH v2 18/18] drm/i915/audio: add DOC comment describing HDA over HDMI/DP Jani Nikula
2014-10-27 18:40 ` Rodrigo Vivi
2014-10-28 14:20 ` [PATCH 1/2] drm/edid: add #defines and helpers for ELD Jani Nikula
2014-10-28 14:20 ` [PATCH 2/2] drm/edid: fix Baseline_ELD_Len field in drm_edid_to_eld() Jani Nikula
2014-11-05 15:37 ` Rodrigo Vivi
2014-11-10 13:39 ` Daniel Vetter
[not found] ` <CAKMK7uF0EFz5DDTJJS9KJ405vgH=FQS5d3FT3spTYp9XxCr-UQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-10 22:38 ` Ben Skeggs
2014-11-10 23:13 ` Daniel Vetter
2014-11-04 23:53 ` [PATCH 1/2] drm/edid: add #defines and helpers for ELD Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103120441.GR26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=rodrigo.vivi@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=shuang.he@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.