Re: [PATCH] ASoC: Intel: Add Merrifield machine driver

[Vinod Koul <vinod.koul@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 821 bytes --]

On Mon, Nov 03, 2014 at 12:07:50PM +0000, Mark Brown wrote:
> On Mon, Nov 03, 2014 at 10:31:58AM +0530, Vinod Koul wrote:
> > On Fri, Oct 31, 2014 at 05:11:27PM +0000, Mark Brown wrote:
> 
> > > > +	snd_jack_set_key(ctx->jack.jack, SND_JACK_BTN_1, KEY_MEDIA);
> > > > +	snd_jack_set_key(ctx->jack.jack, SND_JACK_BTN_0, KEY_MEDIA);
> 
> > > Two buttons both reporting the same key?  Might be worth a comment.
> 
> > Okay loooking back I am not sure why we added two here, let me check and
> > clean this up.
> 
> I was assuming it was because the tolerance desired on the button was
> wider than a single detection range on the device so this was ensuring
> that the button was reliably detected.
and thats is the changelog i found from our old kernel tree. So will add
this coment here...

-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]