From: Dan Carpenter <dan.carpenter@oracle.com>
To: alex.aring@gmail.com
Cc: linux-wpan@vger.kernel.org
Subject: re: ieee802154: add extended address validation helper
Date: Mon, 3 Nov 2014 23:41:13 +0300 [thread overview]
Message-ID: <20141103204113.GA32352@mwanda> (raw)
Hello Alexander Aring,
The patch cb904b0a1630: "ieee802154: add extended address validation
helper" from Nov 2, 2014, leads to the following static checker
warning:
include/linux/ieee802154.h:212 ieee802154_is_valid_extended_addr()
warn: was && intended here instead of ||?
include/linux/ieee802154.h
201 /**
202 * ieee802154_is_valid_psdu_len - check if extended addr is valid
203 * @addr: extended addr to check
204 */
205 static inline bool ieee802154_is_valid_extended_addr(const __le64 addr)
206 {
207 /* These EUI-64 addresses are reserved by IEEE. 0xffffffffffffffff
208 * is used internally as extended to short address broadcast mapping.
209 * This is currently a workaround because neighbor discovery can't
210 * deal with short addresses types right now.
211 */
212 return ((addr != cpu_to_le64(0x0000000000000000ULL)) ||
213 (addr != cpu_to_le64(0xffffffffffffffffULL)));
The current code always returns true. It looks like the static checker
suggestion of change || to && is the correct fix?
214 }
regards,
dan carpenter
next reply other threads:[~2014-11-03 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 20:41 Dan Carpenter [this message]
2014-11-04 0:01 ` ieee802154: add extended address validation helper Alexander Aring
2014-11-04 8:55 ` [patch] ieee802154: || vs && in ieee802154_is_valid_extended_addr() Dan Carpenter
2014-11-04 9:12 ` Alexander Aring
2014-11-04 16:45 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103204113.GA32352@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alex.aring@gmail.com \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.