From: Greg KH <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [char-misc-next V3] mei: add reference counting for me clients
Date: Mon, 3 Nov 2014 15:54:39 -0800 [thread overview]
Message-ID: <20141103235439.GA26158@kroah.com> (raw)
In-Reply-To: <1415004125-5467-1-git-send-email-tomas.winkler@intel.com>
On Mon, Nov 03, 2014 at 10:42:05AM +0200, Tomas Winkler wrote:
> To support dynamic addition/remove we add reference
> counter.
What is keeping two different threads / cpus from grabbing a reference
at the same time the other one is dropping it?
You have a list here, with no locking, right? You also don't have any
locking for your kref, which isn't good at all...
Please audit and fix up.
thanks,
greg k-h
next prev parent reply other threads:[~2014-11-03 23:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 8:42 [char-misc-next V3] mei: add reference counting for me clients Tomas Winkler
2014-11-03 23:54 ` Greg KH [this message]
2014-11-04 5:22 ` Winkler, Tomas
2014-11-06 2:20 ` Greg KH
2014-11-06 8:40 ` Winkler, Tomas
2014-11-06 15:58 ` Greg KH
2014-11-06 19:05 ` Winkler, Tomas
-- strict thread matches above, loose matches on Subject: below --
2015-01-10 22:07 Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103235439.GA26158@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.