From: Greg KH <gregkh@linuxfoundation.org>
To: Feng Kan <fkan@apm.com>
Cc: patches@apm.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, mathias.nyman@intel.com,
Bao Truong <btruong@apm.com>
Subject: Re: [PATCH] usb:host:xhci-plat: 64-bit dma addressing support
Date: Mon, 3 Nov 2014 18:11:03 -0800 [thread overview]
Message-ID: <20141104021103.GA23756@kroah.com> (raw)
In-Reply-To: <1415066368-3829-1-git-send-email-fkan@apm.com>
On Mon, Nov 03, 2014 at 05:59:28PM -0800, Feng Kan wrote:
> Use dma_addr_t to support 64-bit plaforms, which access beyond 32 bit
> address range.
>
> Signed-off-by: Bao Truong <btruong@apm.com>
> Signed-off-by: Feng Kan <fkan@apm.com>
> ---
> drivers/usb/host/xhci-plat.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 01d1862..8cf83f0 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -97,13 +97,14 @@ static int xhci_plat_probe(struct platform_device *pdev)
> }
>
> /* Initialize dma_mask and coherent_dma_mask to 32-bits */
> - ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
> + ret = dma_set_coherent_mask(&pdev->dev,
> + DMA_BIT_MASK(sizeof(dma_addr_t)*8));
Is the comment still correct now?
prev parent reply other threads:[~2014-11-04 2:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 1:59 [PATCH] usb:host:xhci-plat: 64-bit dma addressing support Feng Kan
2014-11-04 2:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104021103.GA23756@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=btruong@apm.com \
--cc=fkan@apm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=patches@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.