From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 10/11] scsi: don't force tagged_supported in drivers Date: Tue, 4 Nov 2014 11:34:26 +0100 Message-ID: <20141104103426.GA19154@lst.de> References: <1415087656-9491-1-git-send-email-hch@lst.de> <1415087656-9491-11-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.211]:51237 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbaKDKec (ORCPT ); Tue, 4 Nov 2014 05:34:32 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Jack Wang Cc: Christoph Hellwig , "linux-scsi@vger.kernel.org" , James Bottomley , Robert Elliott , Hannes Reinecke , "Martin K. Petersen" , Bart van Assche , Jens Axboe , Kashyap Desai , Sreekanth Reddy , Mike Christie , Guennadi Liakhovetski , usb-storage@lists.one-eyed-alien.net On Tue, Nov 04, 2014 at 09:16:30AM +0100, Jack Wang wrote: > > diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c > > index 56d698a..89e8b68 100644 > > --- a/drivers/scsi/libsas/sas_scsi_host.c > > +++ b/drivers/scsi/libsas/sas_scsi_host.c > > @@ -945,7 +945,6 @@ int sas_slave_configure(struct scsi_device *scsi_dev) > > SAS_DPRINTK("device %llx, LUN %llx doesn't support " > > "TCQ\n", SAS_ADDR(dev->sas_addr), > > scsi_dev->lun); > > - scsi_dev->tagged_supported = 0; > > scsi_adjust_queue_depth(scsi_dev, 1); > > } > Hi Christoph, > > The commit msg doesn't match for above, is it intentional ? It's a force off in a branch where it's already guaranteed to be off, but I'll update the description to include this hunk.