From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Hugh Dickins <hughd@google.com>, akpm@linux-foundation.org
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
riel@redhat.com, walken@google.com, aarcange@redhat.com,
linux-mm@kvack.org
Subject: Re: [PATCH] mremap: take anon_vma lock in shared mode
Date: Tue, 4 Nov 2014 14:30:21 +0200 [thread overview]
Message-ID: <20141104123021.GB28274@node.dhcp.inet.fi> (raw)
In-Reply-To: <alpine.LSU.2.11.1411032204420.15596@eggly.anvils>
On Mon, Nov 03, 2014 at 10:08:31PM -0800, Hugh Dickins wrote:
> On Tue, 28 Oct 2014, Kirill A. Shutemov wrote:
>
> > There's no modification to anon_vma interval tree. We only need to
> > serialize against exclusive rmap walker who want s to catch all ptes the
> > page is mapped with. Shared lock is enough for that.
> >
> > Suggested-by: Davidlohr Bueso <dbueso@suse.de>
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
> NAK: please read Michel's comment on need_rmap_locks again, there is
> no point in using read locks on anon_vma (and i_mmap) here, those will
> not exclude the read locks on anon_vma (and i_mmap) in the rmap walk,
> while we move ptes around.
>
> Or am I confused?
Andrew, please drop the patch.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-11-04 12:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 14:40 [PATCH] mremap: take anon_vma lock in shared mode Kirill A. Shutemov
2014-10-28 15:24 ` Rik van Riel
2014-11-04 6:08 ` Hugh Dickins
2014-11-04 12:30 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104123021.GB28274@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.