From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 02/17] drm/tegra: Do not enable output on .mode_set() Date: Tue, 4 Nov 2014 15:50:13 +0100 Message-ID: <20141104145012.GE31200@ulmo> References: <1415006868-318-1-git-send-email-thierry.reding@gmail.com> <1415006868-318-2-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0488838231==" Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 292CD6E06F for ; Tue, 4 Nov 2014 06:50:16 -0800 (PST) Received: by mail-wi0-f171.google.com with SMTP id q5so9635935wiv.4 for ; Tue, 04 Nov 2014 06:50:15 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: dri-devel List-Id: dri-devel@lists.freedesktop.org --===============0488838231== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="phCU5ROyZO6kBE05" Content-Disposition: inline --phCU5ROyZO6kBE05 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 03, 2014 at 12:18:30PM -0500, Sean Paul wrote: > On Mon, Nov 3, 2014 at 4:27 AM, Thierry Reding = wrote: > > From: Thierry Reding > > > > The output is already enabled in .dpms(), doing it in .mode_set() too > > can cause noticeable flicker. > > >=20 > I think this should be coupled with "drm/tegra: DPMS off/on in encoder > prepare/commit" that I sent earlier this week. Without it, the driver > can get into a state where connector status is on, but the output is > disabled. I'm not sure I exactly understand which problem that patch fixes, but I'll give it some testing to see if it doesn't break anything. Thierry --phCU5ROyZO6kBE05 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUWOekAAoJEN0jrNd/PrOhpa0P/i1USue8TdBKStDV3YrOCiMq rLKgDTPtaDjN7UOadECQ+/BZjPDp97xfxhvj8rlV57Gsb7hJ7mNiRdhjg7lMihps 1E70dAfD1Qmp7X3o7s+ffqw52P83nyd2uzSivyXlifuqv++AWbCzA+8jKCUukMUv mSS1gTdCKKCj4nTYK3GmXaCiJI1sb8vwDUuxiJOhgUiauqkKuvxv/CEckQZaCq0q WXRy1CJIII0eR7Ml09gddXkmunYYrLJfQGhpJmaAOVEsqZeFncveO1deFsQIaEUY swBhGyLISf8yf3ZPENqhWd1fQ8cIZ6hEoLnmzoG2QvNuq80Y3EmlS5ZBSr+x04cQ G/Qs0+hhSwAvFjUjozpak5iE1uLpUj6nuRg6Frx/P7ms1Dg7M3EYQz2Ct8PYm7HS TmmaCqG0KkUn/UoD7jkIToIdKUlz29R6wETYNEzu1rKPDCNiX4xxM+W4In8yIpDg YWlVUOhDVAoYp/xI/0n/YscTSy/fcq/88tYlwBU5FfwWQvnyu9Mdf6aTmdA7eIt6 +yluWbU/8TAVPOXdB0MqmyoZzm7YrKpZbi3OBz9Rt7lggi3vFmHOdqP+DpsD+m/2 ZWBOsbIJR16HbALOc2PXx+KNj5TVnt9kgiRR7gZc2a1kViZ10btLAUpOsU3Pa4yr jUJiyBnFo/AfXQfPJOU0 =rdjA -----END PGP SIGNATURE----- --phCU5ROyZO6kBE05-- --===============0488838231== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0488838231==--