From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 03/17] drm/tegra: dsi: Make FIFO depths host parameters Date: Tue, 4 Nov 2014 16:45:25 +0100 Message-ID: <20141104154523.GA1840@ulmo.nvidia.com> References: <1415006868-318-1-git-send-email-thierry.reding@gmail.com> <1415006868-318-3-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0034156128==" Return-path: Received: from mail-pd0-f180.google.com (mail-pd0-f180.google.com [209.85.192.180]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F8216E571 for ; Tue, 4 Nov 2014 07:45:31 -0800 (PST) Received: by mail-pd0-f180.google.com with SMTP id ft15so13883269pdb.11 for ; Tue, 04 Nov 2014 07:45:30 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: dri-devel List-Id: dri-devel@lists.freedesktop.org --===============0034156128== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="d6Gm4EdcadzBjdND" Content-Disposition: inline --d6Gm4EdcadzBjdND Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 03, 2014 at 12:20:24PM -0500, Sean Paul wrote: > On Mon, Nov 3, 2014 at 4:27 AM, Thierry Reding = wrote: > > From: Thierry Reding > > > > Rather than hardcoding them as macros, make the host and video FIFO > > depths parameters so that they can be more easily adjusted if a new > > generation of the Tegra SoC changes them. > > > > Signed-off-by: Thierry Reding > > --- > > drivers/gpu/drm/tegra/dsi.c | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c > > index f7874458926a..584b771d8b2f 100644 > > --- a/drivers/gpu/drm/tegra/dsi.c > > +++ b/drivers/gpu/drm/tegra/dsi.c > > @@ -26,9 +26,6 @@ > > #include "dsi.h" > > #include "mipi-phy.h" > > > > -#define DSI_VIDEO_FIFO_DEPTH (1920 / 4) > > -#define DSI_HOST_FIFO_DEPTH 64 > > - > > struct tegra_dsi { > > struct host1x_client client; > > struct tegra_output output; > > @@ -54,6 +51,9 @@ struct tegra_dsi { > > > > struct regulator *vdd; > > bool enabled; > > + > > + unsigned int video_fifo_depth; > > + unsigned int host_fifo_depth; > > }; > > > > static inline struct tegra_dsi * > > @@ -467,7 +467,7 @@ static int tegra_output_dsi_enable(struct tegra_out= put *output) > > DSI_CONTROL_SOURCE(dc->pipe); > > tegra_dsi_writel(dsi, value, DSI_CONTROL); > > > > - tegra_dsi_writel(dsi, DSI_VIDEO_FIFO_DEPTH, DSI_MAX_THRESHOLD); > > + tegra_dsi_writel(dsi, dsi->video_fifo_depth, DSI_MAX_THRESHOLD); > > > > value =3D DSI_HOST_CONTROL_HS | DSI_HOST_CONTROL_CS | > > DSI_HOST_CONTROL_ECC; > > @@ -843,6 +843,8 @@ static int tegra_dsi_probe(struct platform_device *= pdev) > > return -ENOMEM; > > > > dsi->output.dev =3D dsi->dev =3D &pdev->dev; > > + dsi->video_fifo_depth =3D 1920; >=20 > This is not functionally equivalent to what was previously being set > (1920/4). Perhaps calling that out in the commit message might be > appropriate? Done. Thierry --d6Gm4EdcadzBjdND Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUWPSTAAoJEN0jrNd/PrOhgLgQALlIWSf692ht0zFAYiEMRccX 2T6EpqvoPfiww43Oi70OBWN1+R5FMF9+DmtEp//I3kIKHoXShGAP13AJatd5lxfk Qh3p3otgslLWR4VvyRcVaDWFqClnEogD8qMC5TFLXMXFTMx8uXyy5qia1F0oCGio Yj5mAdAa8uECeazQl5opzD9YhlRDyR9as5ZyqccC6r4YWL40IFJ2ZW5COYJPEDd9 r9txXWrue8GmTJurTMNSBc+NcSQnN+vaAtWdXH+2Uns8/XpiRwbHcDqjPHd51KNp YwYRKdPqSt1To3nJkOZUw1dDB+5oiEkmXVmRqCDaOZ8gQFmf6p3+xwcYhZdi4HOA VGAO4/QVn9VICdAHnCTJDG9mnZkOnxr7morwmdyplJ5RCReD7yLNRV547gYJLx7L jo8aJy5LHFepX4MgkLp0Ml/Ie1s14NRh3+B/G3CnAthqt/V+THGkOU3xZhPyvehz ePJAoTVH22eTOKo6SSNy4xMB0u6W0MMUn6MJ7lK2D6oV5C7VqT+yiBT1NNnlNTj8 7WuvXYUTvlNPNHadkPvvyGiy65Z3q1EAQTN8Bh01EMtYFz4aiCNV5o8cTNdRozNY WZ3Sjjz482RekcpfBObFth6JkWzXS/nAA/ot2lgzhiTGt+4r1l9x7IO2fYXxA56u zDwrrDwHLoZhoOJfzbPG =69Dy -----END PGP SIGNATURE----- --d6Gm4EdcadzBjdND-- --===============0034156128== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0034156128==--