From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 628F61A0349 for ; Wed, 5 Nov 2014 03:08:28 +1100 (AEDT) Date: Tue, 4 Nov 2014 08:07:16 -0800 From: Greg Kroah-Hartman To: Grant Likely Subject: Re: [PATCH] of/platform: Move platform devices under /sys/devices/platform Message-ID: <20141104160716.GA1630@kroah.com> References: <1415097920-30014-1-git-send-email-grant.likely@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1415097920-30014-1-git-send-email-grant.likely@linaro.org> Cc: devicetree@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, Rob Herring , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Nov 04, 2014 at 10:45:20AM +0000, Grant Likely wrote: > Currently the devices created by drivers/of/platform.c get created at > the root of /sys/devices. This goes against the typical pattern for > sysfs where the top level /sys/devices structure contains categories of > devices, and the structure of devices is placed below that. To fix this, > make the code in drivers/of/platform.c follow the drivers/base/platform.c > behaviour, and use &platform_bus as the default parent for all new > platform_devices and amba_devices. > > This change has been discussed for a long time, but nobody has actually > acted on it. Userspace code that expects to find devices under a fixed > /sys/devices/... path will be affected. It isn't /supposed/ to do that, > but if anyone complains then I'll add a default-off workaround option to > put them back into the root. > > Signed-off-by: Grant Likely > Cc: Rob Herring > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman Acked-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Tue, 4 Nov 2014 08:07:16 -0800 Subject: [PATCH] of/platform: Move platform devices under /sys/devices/platform In-Reply-To: <1415097920-30014-1-git-send-email-grant.likely@linaro.org> References: <1415097920-30014-1-git-send-email-grant.likely@linaro.org> Message-ID: <20141104160716.GA1630@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Nov 04, 2014 at 10:45:20AM +0000, Grant Likely wrote: > Currently the devices created by drivers/of/platform.c get created at > the root of /sys/devices. This goes against the typical pattern for > sysfs where the top level /sys/devices structure contains categories of > devices, and the structure of devices is placed below that. To fix this, > make the code in drivers/of/platform.c follow the drivers/base/platform.c > behaviour, and use &platform_bus as the default parent for all new > platform_devices and amba_devices. > > This change has been discussed for a long time, but nobody has actually > acted on it. Userspace code that expects to find devices under a fixed > /sys/devices/... path will be affected. It isn't /supposed/ to do that, > but if anyone complains then I'll add a default-off workaround option to > put them back into the root. > > Signed-off-by: Grant Likely > Cc: Rob Herring > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman Acked-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH] of/platform: Move platform devices under /sys/devices/platform Date: Tue, 4 Nov 2014 08:07:16 -0800 Message-ID: <20141104160716.GA1630@kroah.com> References: <1415097920-30014-1-git-send-email-grant.likely@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1415097920-30014-1-git-send-email-grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grant Likely Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , Arnd Bergmann , Benjamin Herrenschmidt List-Id: devicetree@vger.kernel.org On Tue, Nov 04, 2014 at 10:45:20AM +0000, Grant Likely wrote: > Currently the devices created by drivers/of/platform.c get created at > the root of /sys/devices. This goes against the typical pattern for > sysfs where the top level /sys/devices structure contains categories of > devices, and the structure of devices is placed below that. To fix this, > make the code in drivers/of/platform.c follow the drivers/base/platform.c > behaviour, and use &platform_bus as the default parent for all new > platform_devices and amba_devices. > > This change has been discussed for a long time, but nobody has actually > acted on it. Userspace code that expects to find devices under a fixed > /sys/devices/... path will be affected. It isn't /supposed/ to do that, > but if anyone complains then I'll add a default-off workaround option to > put them back into the root. > > Signed-off-by: Grant Likely > Cc: Rob Herring > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754754AbaKDQI2 (ORCPT ); Tue, 4 Nov 2014 11:08:28 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45093 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752470AbaKDQI0 (ORCPT ); Tue, 4 Nov 2014 11:08:26 -0500 Date: Tue, 4 Nov 2014 08:07:16 -0800 From: Greg Kroah-Hartman To: Grant Likely Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Rob Herring , Arnd Bergmann , Benjamin Herrenschmidt Subject: Re: [PATCH] of/platform: Move platform devices under /sys/devices/platform Message-ID: <20141104160716.GA1630@kroah.com> References: <1415097920-30014-1-git-send-email-grant.likely@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1415097920-30014-1-git-send-email-grant.likely@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 04, 2014 at 10:45:20AM +0000, Grant Likely wrote: > Currently the devices created by drivers/of/platform.c get created at > the root of /sys/devices. This goes against the typical pattern for > sysfs where the top level /sys/devices structure contains categories of > devices, and the structure of devices is placed below that. To fix this, > make the code in drivers/of/platform.c follow the drivers/base/platform.c > behaviour, and use &platform_bus as the default parent for all new > platform_devices and amba_devices. > > This change has been discussed for a long time, but nobody has actually > acted on it. Userspace code that expects to find devices under a fixed > /sys/devices/... path will be affected. It isn't /supposed/ to do that, > but if anyone complains then I'll add a default-off workaround option to > put them back into the root. > > Signed-off-by: Grant Likely > Cc: Rob Herring > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman Acked-by: Greg Kroah-Hartman