From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XljR1-0006Fv-Jp for qemu-devel@nongnu.org; Tue, 04 Nov 2014 14:06:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XljQw-0000YF-Vy for qemu-devel@nongnu.org; Tue, 04 Nov 2014 14:06:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XljQw-0000Xz-NY for qemu-devel@nongnu.org; Tue, 04 Nov 2014 14:06:26 -0500 Date: Tue, 4 Nov 2014 19:06:05 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20141104190604.GF14394@work-vm> References: <1412358473-31398-1-git-send-email-dgilbert@redhat.com> <1412358473-31398-8-git-send-email-dgilbert@redhat.com> <20141103024524.GE8949@voom.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141103024524.GE8949@voom.redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 07/47] Create MigrationIncomingState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, cristian.klein@cs.umu.se, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com * David Gibson (david@gibson.dropbear.id.au) wrote: > On Fri, Oct 03, 2014 at 06:47:13PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > There are currently lots of pieces of incoming migration state scattered > > around, and postcopy is adding more, and it seems better to try and keep > > it together. > > > > allocate MIS in process_incoming_migration_co > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > include/migration/migration.h | 9 +++++++++ > > include/qemu/typedefs.h | 2 ++ > > migration.c | 28 ++++++++++++++++++++++++++++ > > savevm.c | 2 ++ > > 4 files changed, 41 insertions(+) > > > > diff --git a/include/migration/migration.h b/include/migration/migration.h > > index 3cb5ba8..8a36255 100644 > > --- a/include/migration/migration.h > > +++ b/include/migration/migration.h > > @@ -41,6 +41,15 @@ struct MigrationParams { > > > > typedef struct MigrationState MigrationState; > > > > +/* State for the incoming migration */ > > +struct MigrationIncomingState { > > + QEMUFile *file; > > +}; > > + > > +MigrationIncomingState *migration_incoming_get_current(void); > > +MigrationIncomingState *migration_incoming_state_init(QEMUFile *f); > > Hrm. I'd prefer to see this called migration_incoming_state_new(), > since it allocates a new structure, rather than just initializing an > already allocated one. > > I guess you're trying to match migrate_init() in name, so i guess > migrate_incoming_init() would work as well. No, you're right the 1st time, _new is more consistent; fixed. Dave > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK