Re: [PATCH] Thermal/int3403: Fix thermal hysteresis unit conversion

[Eduardo Valentin <edubezval@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

Rui,

On Tue, Nov 04, 2014 at 09:50:34AM +0800, Zhang Rui wrote:
> On 一, 2014-11-03 at 01:53 -0800, Srinivas Pandruvada wrote:
> > From: "lan,Tianyu" <tianyu.lan@intel.com>
> > 
> > Thermal hysteresis represents a temperature difference.
> > But the original code treats it as a temperature value,
> > Convert it from tenths of degree Kelvin to Milli-Celsius
> > by deducing 273200. This is not right.
> > 
> > Kelvin and Celsius have same degree size. From temperature
> > difference view, the conversion between tenths of degree
> > Kelvin unit and Milli-Celsius unit is just to multiply 100.
> > 
> > Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> 
> Hi, Eduardo,
> 
> can you please queue this patch for 3.18-rc5?
> 

Pulled into my -fixes queue. Thanks.

> thanks,
> rui
> > ---
> >  drivers/thermal/int340x_thermal/int3403_thermal.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/thermal/int340x_thermal/int3403_thermal.c b/drivers/thermal/int340x_thermal/int3403_thermal.c
> > index d20dba9..6e9fb62 100644
> > --- a/drivers/thermal/int340x_thermal/int3403_thermal.c
> > +++ b/drivers/thermal/int340x_thermal/int3403_thermal.c
> > @@ -92,7 +92,13 @@ static int sys_get_trip_hyst(struct thermal_zone_device *tzone,
> >  	if (ACPI_FAILURE(status))
> >  		return -EIO;
> >  
> > -	*temp = DECI_KELVIN_TO_MILLI_CELSIUS(hyst, KELVIN_OFFSET);
> > +	/*
> > +	 * Thermal hysteresis represents a temperature difference.
> > +	 * Kelvin and Celsius have same degree size. So the
> > +	 * conversion here between tenths of degree Kelvin unit
> > +	 * and Milli-Celsius unit is just to multiply 100.
> > +	 */
> > +	*temp = hyst * 100;
> >  
> >  	return 0;
> >  }
> 
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]