All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH 0/6 v2] xfs: fix the bulkstat mess
Date: Wed, 5 Nov 2014 17:07:28 +1100	[thread overview]
Message-ID: <20141105060728.GE28565@dastard> (raw)
In-Reply-To: <1415145921-31507-1-git-send-email-david@fromorbit.com>

On Wed, Nov 05, 2014 at 11:05:15AM +1100, Dave Chinner wrote:
> Hi folks, this is version 2 of the bulkstat fixup series first
> posted here:
> 
> http://oss.sgi.com/archives/xfs/2014-11/msg00057.html
> 
> Version 2 fixes the issues Brian found during review:
> - chunk formatter error leakage (patch 3)
> - moved main loop chunk formatter error handling from patch 4 to
>   patch 5
> - reworks last_agino updating in patch 6 to do post-formatting
>   updates and added comments.
> 
> Comeents and testing welcome.

I'm not 100% convinced that this fixes all the problems. I just
created, dumped and restored a 10 million inode filesystem (about
50GB of dump file) and I found 102 missing files in the dump with no
errors from xfsdump or xfsrestore.

The files are missing from just 4 directories out of about 1000
directories containing equal numbers of files, so its not a common
trigger whatever the issue is. I'll keep digging...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2014-11-05  6:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05  0:05 [PATCH 0/6 v2] xfs: fix the bulkstat mess Dave Chinner
2014-11-05  0:05 ` [PATCH 1/6] xfs: bulkstat btree walk doesn't terminate Dave Chinner
2014-11-05  0:05 ` [PATCH 2/6] xfs: bulkstat chunk formatting cursor is broken Dave Chinner
2014-11-05  0:05 ` [PATCH 3/6] xfs: bulkstat chunk-formatter has issues Dave Chinner
2014-11-05 14:59   ` Brian Foster
2014-11-05  0:05 ` [PATCH 4/6] xfs: bulkstat main loop logic is a mess Dave Chinner
2014-11-05  0:05 ` [PATCH 5/6] xfs: bulkstat error handling is broken Dave Chinner
2014-11-05  0:05 ` [PATCH 6/6] xfs: track bulkstat progress by agino Dave Chinner
2014-11-05 15:14   ` Brian Foster
2014-11-05  6:07 ` Dave Chinner [this message]
2014-11-05  6:32   ` [PATCH 0/6 v2] xfs: fix the bulkstat mess Dave Chinner
2014-11-05 13:17     ` Brian Foster
2014-11-05 21:21       ` Dave Chinner
2014-11-06  6:53         ` Dave Chinner
2014-11-06 12:49           ` Brian Foster
2014-11-06 13:02             ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141105060728.GE28565@dastard \
    --to=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.