All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
	linux-wireless@vger.kernel.org,
	Michal Kazior <michal.kazior@tieto.com>,
	ath10k@lists.infradead.org
Subject: Re: [PATCH v2] ath10k: handle ieee80211 header and payload tracing separately
Date: Wed, 5 Nov 2014 16:14:59 +0530	[thread overview]
Message-ID: <20141105104458.GA13249@qca.qualcomm.com> (raw)
In-Reply-To: <1415182321.2589.14.camel@sipsolutions.net>

On Wed, Nov 05, 2014 at 11:12:01AM +0100, Johannes Berg wrote:
> On Wed, 2014-11-05 at 15:14 +0530, Rajkumar Manoharan wrote:
> 
> > The macro is defined to ease readability and reduce # of line changes.
> > I originally thought of naming the macro as IEEE80211_HDR_LEN. But such
> > definition does not look correct inside driver.
> 
> FWIW, I pointed Kalle to the macro on IRC - IMHO you should pass
> arguments to the macro (and probably even make it an inline function)
> rather than having it assume certain variables exist when the macro is
> used.
> 
> Kalle may have misunderstood what I was trying to say :)
> 
Sounds clear..Thanks for pointing out. Will change it as inline funtion..

-Rajkumar

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>, <ath10k@lists.infradead.org>,
	<linux-wireless@vger.kernel.org>,
	Michal Kazior <michal.kazior@tieto.com>
Subject: Re: [PATCH v2] ath10k: handle ieee80211 header and payload tracing separately
Date: Wed, 5 Nov 2014 16:14:59 +0530	[thread overview]
Message-ID: <20141105104458.GA13249@qca.qualcomm.com> (raw)
In-Reply-To: <1415182321.2589.14.camel@sipsolutions.net>

On Wed, Nov 05, 2014 at 11:12:01AM +0100, Johannes Berg wrote:
> On Wed, 2014-11-05 at 15:14 +0530, Rajkumar Manoharan wrote:
> 
> > The macro is defined to ease readability and reduce # of line changes.
> > I originally thought of naming the macro as IEEE80211_HDR_LEN. But such
> > definition does not look correct inside driver.
> 
> FWIW, I pointed Kalle to the macro on IRC - IMHO you should pass
> arguments to the macro (and probably even make it an inline function)
> rather than having it assume certain variables exist when the macro is
> used.
> 
> Kalle may have misunderstood what I was trying to say :)
> 
Sounds clear..Thanks for pointing out. Will change it as inline funtion..

-Rajkumar

  reply	other threads:[~2014-11-05 10:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30  9:28 [PATCH v2] ath10k: handle ieee80211 header and payload tracing separately Rajkumar Manoharan
2014-10-30  9:28 ` Rajkumar Manoharan
2014-11-03 23:34 ` Kalle Valo
2014-11-03 23:34   ` Kalle Valo
2014-11-04  5:16   ` Rajkumar Manoharan
2014-11-04  5:16     ` Rajkumar Manoharan
2014-11-05  1:29     ` Kalle Valo
2014-11-05  1:29       ` Kalle Valo
2014-11-05  9:44       ` Rajkumar Manoharan
2014-11-05  9:44         ` Rajkumar Manoharan
2014-11-05 10:12         ` Johannes Berg
2014-11-05 10:12           ` Johannes Berg
2014-11-05 10:44           ` Rajkumar Manoharan [this message]
2014-11-05 10:44             ` Rajkumar Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141105104458.GA13249@qca.qualcomm.com \
    --to=rmanohar@qti.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.